Attachment 37324 Details for Bug 6950 – Bug 6950: Hide the resort option when searching for a tag

[patch] Bug 6950: Hide the resort option when searching for a tag

Bug-6950-Hide-the-resort-option-when-searching-for.patch (text/plain), 2.81 KB, created by Jonathan Druart on 2015-03-27 14:44:09 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: Jonathan Druart

Created: 2015-03-27 14:44:09 UTC

Size: 2.81 KB

patch

obsolete

>From feffa46da6b905a81d0282571415c66cb37c9949 Mon Sep 17 00:00:00 2001
>From: Jonathan Druart <jonathan.druart@biblibre.com>
>Date: Fri, 27 Mar 2015 10:47:40 +0100
>Subject: [PATCH] Bug 6950: Hide the resort option when searching for a tag
>
>If you click a link from the Tag Cloud, the results page offers the
>usual select menu to resort your results. However, doing so resubmits
>the search as a standard keyword search.
>
>Test plan:
>1/ Click on a tag
>2/ Confirm that the resort dropdown list does not appear.
>---
> koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-results.tt | 10 ++++++----
> opac/opac-search.pl                                      |  6 ++++--
> 2 files changed, 10 insertions(+), 6 deletions(-)
>
>diff --git a/koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-results.tt b/koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-results.tt
>index fd2cb9f..4bd8bd4 100644
>--- a/koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-results.tt
>+++ b/koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-results.tt
>@@ -131,10 +131,12 @@
>                                             <a href="#" class="highlight_toggle" id="highlight_toggle_on">Highlight</a>
>                                         </div>
>                                     [% END %]
>-                                    <div class="sort_by pull-right">
>-                                        <select id="sort_by" class="resort" name="sort_by"> [% INCLUDE 'resort_form.inc' %] </select>
>-                                        <input type="submit" class="btn btn-small clearfix" id="sortsubmit" value="Go" />
>-                                    </div>
>+                                    [% UNLESS tag %]
>+                                        <div class="sort_by pull-right">
>+                                            <select id="sort_by" class="resort" name="sort_by"> [% INCLUDE 'resort_form.inc' %] </select>
>+                                            <input type="submit" class="btn btn-small clearfix" id="sortsubmit" value="Go" />
>+                                        </div>
>+                                    [% END %]
>                                 </div> 
> 
>                                 <div id="selections-toolbar" class="toolbar noprint">
>diff --git a/opac/opac-search.pl b/opac/opac-search.pl
>index cdf0fbb..6301adf 100755
>--- a/opac/opac-search.pl
>+++ b/opac/opac-search.pl
>@@ -347,8 +347,10 @@ if ( $template_type && $template_type eq 'advsearch' ) {
> #  * multivalued CGI paramaters are returned as a packaged string separated by "\0" (null)
> my $params = $cgi->Vars;
> my $tag;
>-$tag = $params->{tag} if $params->{tag};
>-
>+if ( $params->{tag} ) {
>+    $tag = $params->{tag};
>+    $template->param( tag => $tag );
>+}
> 
> # String with params with the search criteria for the paging in opac-detail
> # param value is URI encoded and params separator is HTML encode (&amp;)
>-- 
>2.1.0

Actions: View | Diff | Splinter Review

Attachments on bug 6950: 37284 | 37299 | 37324 | 37327 | 37512 | 37513