Attachment 37354 Details for Bug 4502 – Bug 4502: Catch software error if no active budget defined

[patch] Bug 4502: Catch software error if no active budget defined

Bug-4502-Catch-software-error-if-no-active-budget-.patch (text/plain), 2.53 KB, created by Mark Tompsett on 2015-03-30 04:17:40 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: Mark Tompsett

Created: 2015-03-30 04:17:40 UTC

Size: 2.53 KB

patch

obsolete

>From e982fae875f929c63861dcee55e2de7a2a1d7ddc Mon Sep 17 00:00:00 2001
>From: Jonathan Druart <jonathan.druart@biblibre.com>
>Date: Tue, 24 Mar 2015 15:54:37 +0100
>Subject: [PATCH] Bug 4502: Catch software error if no active budget defined
>
>TEST PLAN
>---------
>0) Back up your database.
>1) In mysql client:
>   > DROP DATABASE {your koha database name};
>   > CREATE DATABASE {your koha database name};
>   > QUIT;
>2) Go to the staff client, and install all the default
>   and optional things -- except patrons. :)
>3) Log into staff client.
>4) Create a patron -> New Patron -> Staff
>5) Enter data and Save
>6) More -> Set Permissions
>7) Make superlibrarian
>8) Log out
>9) Log in as new superlibrarian
>10) Acquisitions -> Budgets -> New Budget
>11) Enter a non-active budget with some funds.
>    -- Once saved, it should list in the inactive budgets.
>12) Click on the name.
>13) Click on one of the Planning submenu options.
>14) Click the 'Submit' button in the Filter area.
>    -- This should trigger the blow up.
>15) Apply the patch
>16) Repeat steps 12-15
>    -- The kaboom is avoided and a nice message given.
>
>NOTE: This does not solve all the problems in this ugly, ugly
>      module area. It does solve the one thing it is meant to:
>      that nasty kaboom.
>
>Signed-off-by: Mark Tompsett <mtompset@hotmail.com>
>---
> admin/aqplan.pl                                         | 4 ++++
> koha-tmpl/intranet-tmpl/prog/en/modules/admin/aqplan.tt | 2 ++
> 2 files changed, 6 insertions(+)
>
>diff --git a/admin/aqplan.pl b/admin/aqplan.pl
>index dda1d21..e792ca2 100755
>--- a/admin/aqplan.pl
>+++ b/admin/aqplan.pl
>@@ -106,6 +106,10 @@ if ( $budget_period_locked == 1  && not defined  $show_actual ) {
> 
> $authcat = 'Asort1' if  not defined $authcat; # defaults to Asort if no authcat given
> 
>+# If no active budget is defined, budget_period_id is undef
>+# This is the behavior of GetBudgetPeriod
>+$authcat = '' unless $budget_period_id;
>+
> my $budget_id = $input->param('budget_id');
> my $op        = $input->param("op");
> 
>diff --git a/koha-tmpl/intranet-tmpl/prog/en/modules/admin/aqplan.tt b/koha-tmpl/intranet-tmpl/prog/en/modules/admin/aqplan.tt
>index b465f8c..2cfb912 100644
>--- a/koha-tmpl/intranet-tmpl/prog/en/modules/admin/aqplan.tt
>+++ b/koha-tmpl/intranet-tmpl/prog/en/modules/admin/aqplan.tt
>@@ -224,6 +224,8 @@
> 
> </form>
> 
>+        [% ELSIF not budget_period_id %]
>+<div class="dialog alert">No active budget defined. You should define one before continuing.</div>
>         [% ELSE %]
> <div class="dialog message">No funds to display for this search criteria</div>
>         [% END %]
>-- 
>1.9.1

Actions: View | Diff | Splinter Review

Attachments on bug 4502: 37181 | 37203 | 37354 | 37533 | 37534 | 39081 | 39082 | 39083 | 39084 | 42771 | 44498 | 44499 | 44500 | 44932 | 44945 | 44946 | 44947