Bugzilla – Attachment 37414 Details for
Bug 8050
debian/build-git-snapshot should warn user if it fails
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
Bug 8050: Die if package building fails
Bug-8050-Die-if-package-building-fails.patch (text/plain), 869 bytes, created by
Jonathan Druart
on 2015-04-01 09:38:34 UTC
(
hide
)
Description:
Bug 8050: Die if package building fails
Filename:
MIME Type:
Creator:
Jonathan Druart
Created:
2015-04-01 09:38:34 UTC
Size:
869 bytes
patch
obsolete
>From f34d8a347c1af7e6363d7eeab001f44087794bd3 Mon Sep 17 00:00:00 2001 >From: Jonathan Druart <jonathan.druart@biblibre.com> >Date: Wed, 1 Apr 2015 11:35:55 +0200 >Subject: [PATCH] Bug 8050: Die if package building fails > >The debian/build-git-snapshot script should not return success if an >error occurred. > >Note that sys_command_output won't raise an error if something fails. >--- > debian/build-git-snapshot | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > >diff --git a/debian/build-git-snapshot b/debian/build-git-snapshot >index a2a0e9f..2e2c481 100755 >--- a/debian/build-git-snapshot >+++ b/debian/build-git-snapshot >@@ -62,7 +62,7 @@ sub sys_command_output_screen { > my ($command) = @_; > > print "$command\n" if $debug; >- system($command); >+ system($command) == 0 or die "Command returns an error ($?)"; > } > > sub everything_is_committed { >-- >2.1.0
<b>You cannot view the attachment while viewing its details because your browser does not support IFRAMEs. <a href="attachment.cgi?id=37414">View the attachment on a separate page</a>.</b>
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 8050
:
37414
|
37425
|
37453