Attachment 37434 Details for Bug 13896 – Bug 13896: Fix pid file creation, use proper directory instead of /tmp/

[patch] Bug 13896: Fix pid file creation, use proper directory instead of /tmp/

Bug-13896-Fix-pid-file-creation-use-proper-directo.patch (text/plain), 1.50 KB, created by Mark Tompsett on 2015-04-02 12:49:06 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: Mark Tompsett

Created: 2015-04-02 12:49:06 UTC

Size: 1.50 KB

patch

obsolete

>From db866bbc9fa60ddf4519be134a3d19955480b0e4 Mon Sep 17 00:00:00 2001
>From: Attila Kinali <attila@kinali.ch>
>Date: Mon, 23 Mar 2015 22:58:22 +0100
>Subject: [PATCH] Bug 13896: Fix pid file creation, use proper directory
> instead of /tmp/
>
>daemon uses by default /tmp/ for pid files, if they are unspecified.
>Pass the right directory to daemon, so it knows where to put the pid file.
>
>Signed-off-by: Attila Kinali <attila@kinali.ch>
>
>TEST PLAN
>---------
>1) Roll a distribution and confirm it works.
>
>OR
>
>1) Hack all the /var directories to point to git directories
>2) Add a dummy user for the instance name
>3) sudo the script with the faked instance name.
>   -- the daemon should be running and the pid file should be in
>      the expected directory.
>
>The first way is the proper way to test, I did the latter. :)
>
>Signed-off-by: Mark Tompsett <mtompset@hotmail.com>
>---
> debian/scripts/koha-start-zebra | 1 +
> 1 file changed, 1 insertion(+)
>
>diff --git a/debian/scripts/koha-start-zebra b/debian/scripts/koha-start-zebra
>index 185a650..ce6c469 100755
>--- a/debian/scripts/koha-start-zebra
>+++ b/debian/scripts/koha-start-zebra
>@@ -40,6 +40,7 @@ start_zebra_instance()
>         "/var/log/koha/$instancename/zebra-output.log"
>     daemon \
>         --name="$instancename-koha-zebra" \
>+        --pidfiles="/var/run/koha/$instancename/" \
>         --errlog="/var/log/koha/$instancename/zebra-error.log" \
>         --stdout="/var/log/koha/$instancename/zebra.log" \
>         --output="/var/log/koha/$instancename/zebra-output.log" \
>-- 
>1.9.1

Actions: View | Diff | Splinter Review

Attachments on bug 13896: 37164 | 37434 | 37460 | 37589