Attachment 37461 Details for Bug 13947 – [PASSED QA] Bug 13947: Correct call to GetBiblio to receive correct return value

[patch] [PASSED QA] Bug 13947: Correct call to GetBiblio to receive correct return value

PASSED-QA-Bug-13947-Correct-call-to-GetBiblio-to-r.patch (text/plain), 1.58 KB, created by Kyle M Hall (khall) on 2015-04-03 17:27:27 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: Kyle M Hall (khall)

Created: 2015-04-03 17:27:27 UTC

Size: 1.58 KB

patch

obsolete

>From 19d13a5014dcdc489b565518cc691876a47b67f5 Mon Sep 17 00:00:00 2001
>From: Mark Tompsett <mtompset@hotmail.com>
>Date: Thu, 2 Apr 2015 11:15:14 -0400
>Subject: [PATCH] [PASSED QA] Bug 13947: Correct call to GetBiblio to receive correct return value
>
>When you attempt to edit the manual history for a subscription,
>the title is blank. This is a result of an incorrect use of the
>GetBiblio function.
>
>TEST PLAN
>---------
>1) Log in to staff client
>2) Serials
>3) Search for an existing serial with manual history checked.
>   -- creating one as needed is left as an exercise to the reader.
>4) Click on the title of the serial for the details page.
>5) Go to the Planning tab and click 'Edit History'
>   -- Heading will be 'Subscription history for' without a
>      title.
>6) Apply patch
>7) Refresh page.
>   -- Heading will include the title correctly.
>8) run koha qa test tools
>
>Signed-off-by: Jacek Ablewicz <abl@biblos.pk.edu.pl>
>
>Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com>
>---
> serials/subscription-history.pl |    2 +-
> 1 files changed, 1 insertions(+), 1 deletions(-)
>
>diff --git a/serials/subscription-history.pl b/serials/subscription-history.pl
>index 9310b5d..267afcb 100755
>--- a/serials/subscription-history.pl
>+++ b/serials/subscription-history.pl
>@@ -71,7 +71,7 @@ if($op && $op eq 'mod') {
>     exit;
> } else {
>     my $history = GetSubscriptionHistoryFromSubscriptionId($subscriptionid);
>-    my (undef, $biblio) = GetBiblio($history->{'biblionumber'});
>+    my $biblio  = GetBiblio($history->{'biblionumber'});
> 
>     $template->param(
>         subscriptionid  => $subscriptionid,
>-- 
>1.7.2.5

Actions: View | Diff | Splinter Review

Attachments on bug 13947: 37443 | 37447 | 37461