Attachment 37513 Details for Bug 6950 – [PASSED QA] Bug 6950: Hide the resort option when searching for a tag

[patch] [PASSED QA] Bug 6950: Hide the resort option when searching for a tag

PASSED-QA-Bug-6950-Hide-the-resort-option-when-sea.patch (text/plain), 3.06 KB, created by Katrin Fischer on 2015-04-05 21:14:19 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: Katrin Fischer

Created: 2015-04-05 21:14:19 UTC

Size: 3.06 KB

patch

obsolete

>From 60f913505cbcdee4d1860dac850e05cbca78c3c8 Mon Sep 17 00:00:00 2001
>From: Jonathan Druart <jonathan.druart@biblibre.com>
>Date: Fri, 27 Mar 2015 10:47:40 +0100
>Subject: [PATCH] [PASSED QA] Bug 6950: Hide the resort option when searching
> for a tag
>MIME-Version: 1.0
>Content-Type: text/plain; charset=UTF-8
>Content-Transfer-Encoding: 8bit
>
>If you click a link from the Tag Cloud, the results page offers the
>usual select menu to resort your results. However, doing so resubmits
>the search as a standard keyword search.
>
>Test plan:
>1/ Click on a tag
>2/ Confirm that the resort dropdown list does not appear.
>
>Dropdown list disappears with tags as expected.
>Signed-off-by: Marc VÃ©ron <veron@veron.ch>
>
>Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de>
>---
> koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-results.tt | 10 ++++++----
> opac/opac-search.pl                                      |  6 ++++--
> 2 files changed, 10 insertions(+), 6 deletions(-)
>
>diff --git a/koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-results.tt b/koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-results.tt
>index 948c069..928fa67 100644
>--- a/koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-results.tt
>+++ b/koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-results.tt
>@@ -131,10 +131,12 @@
>                                             <a href="#" class="highlight_toggle" id="highlight_toggle_on">Highlight</a>
>                                         </div>
>                                     [% END %]
>-                                    <div class="sort_by pull-right">
>-                                        <select id="sort_by" class="resort" name="sort_by"> [% INCLUDE 'resort_form.inc' %] </select>
>-                                        <input type="submit" class="btn btn-small clearfix" id="sortsubmit" value="Go" />
>-                                    </div>
>+                                    [% UNLESS tag %]
>+                                        <div class="sort_by pull-right">
>+                                            <select id="sort_by" class="resort" name="sort_by"> [% INCLUDE 'resort_form.inc' %] </select>
>+                                            <input type="submit" class="btn btn-small clearfix" id="sortsubmit" value="Go" />
>+                                        </div>
>+                                    [% END %]
>                                 </div> 
> 
>                                 <div id="selections-toolbar" class="toolbar noprint">
>diff --git a/opac/opac-search.pl b/opac/opac-search.pl
>index f634f12..aa00f89 100755
>--- a/opac/opac-search.pl
>+++ b/opac/opac-search.pl
>@@ -345,8 +345,10 @@ if ( $template_type && $template_type eq 'advsearch' ) {
> #  * multivalued CGI paramaters are returned as a packaged string separated by "\0" (null)
> my $params = $cgi->Vars;
> my $tag;
>-$tag = $params->{tag} if $params->{tag};
>-
>+if ( $params->{tag} ) {
>+    $tag = $params->{tag};
>+    $template->param( tag => $tag );
>+}
> 
> # String with params with the search criteria for the paging in opac-detail
> # param value is URI encoded and params separator is HTML encode (&amp;)
>-- 
>1.9.1

Actions: View | Diff | Splinter Review

Attachments on bug 6950: 37284 | 37299 | 37324 | 37327 | 37512 | 37513