Attachment 37527 Details for Bug 13821 – Bug 13812 - Facet links broken because double-quotes are not URL encoded.

[patch] Bug 13812 - Facet links broken because double-quotes are not URL encoded.

Bug-13812---Facet-links-broken-because-double-quot.patch (text/plain), 2.34 KB, created by Kyle M Hall (khall) on 2015-04-06 12:56:23 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: Kyle M Hall (khall)

Created: 2015-04-06 12:56:23 UTC

Size: 2.34 KB

patch

obsolete

>From dd5bd8e484621a1a9eb6ab9a7a62f5ce17c53446 Mon Sep 17 00:00:00 2001
>From: =?UTF-8?q?=E2=80=9CByWater?= <âstaff@bywatersolutions.comâ>
>Date: Mon, 6 Apr 2015 05:49:35 -0700
>Subject: [PATCH] Bug 13812 - Facet links broken because double-quotes are not URL encoded.
>
>This bug is analogous to Bug 13442, but it affects shelf location rather than collection code:
>
>Limiting a search by shelf location is broken, because it wraps double-quotes around the "value" part of the key-value pair in the URL. This breaks the href= part of the anchor tag.
>
>The anchor tag generated for the shelf location faced is
>
><a href="/cgi-bin/koha/opac-search.pl?&limit=mc-loc%3A"100100ADFICCF"&limit=mc-loc%3A"100200ADFIC"&limit=mc-loc%3A"100250ADFICGN"&limit=mc-loc%3A"100300ADFICHF"&limit=yr%2Cst-numeric%3D2014-&amp;sort_by=acqdate_dsc&amp;limit=au:Paetro%2C%20Maxine%2C" title="Paetro, Maxine,">Paetro, Maxine,</a>
>
>Once again, double-quotes inside the URL are causing a premature close of the href, which results in a broken link.
>
>http://bugs.koha-community.org/show_bug.cgi?id=13821
>---
> .../bootstrap/en/xslt/MARC21slim2OPACDetail.xsl    |    4 ++--
> 1 files changed, 2 insertions(+), 2 deletions(-)
>
>diff --git a/koha-tmpl/opac-tmpl/bootstrap/en/xslt/MARC21slim2OPACDetail.xsl b/koha-tmpl/opac-tmpl/bootstrap/en/xslt/MARC21slim2OPACDetail.xsl
>index 11624c4..11daa79c 100644
>--- a/koha-tmpl/opac-tmpl/bootstrap/en/xslt/MARC21slim2OPACDetail.xsl
>+++ b/koha-tmpl/opac-tmpl/bootstrap/en/xslt/MARC21slim2OPACDetail.xsl
>@@ -585,8 +585,8 @@
>                 <xsl:attribute name="href">/cgi-bin/koha/opac-search.pl?q=<xsl:call-template name="subfieldSelect">
>                         <xsl:with-param name="codes">abcdfgklmnopqrstvxyz</xsl:with-param>
>                         <xsl:with-param name="delimeter"> AND </xsl:with-param>
>-                        <xsl:with-param name="prefix">(su<xsl:value-of select="$SubjectModifier"/>:<xsl:value-of select="$TracingQuotesLeft"/></xsl:with-param>
>-                        <xsl:with-param name="suffix"><xsl:value-of select="$TracingQuotesRight"/>)</xsl:with-param>
>+                        <xsl:with-param name="prefix">(su<xsl:value-of select="$SubjectModifier"/>:</xsl:with-param>
>+                        <xsl:with-param name="suffix"></xsl:with-param>
>                     </xsl:call-template>
>                 </xsl:attribute>
>             </xsl:when>
>-- 
>1.7.2.5

Actions: View | Diff | Splinter Review

Attachments on bug 13821: 37527