Attachment 37549 Details for Bug 13957 – Bug 13957: If no value, display an empty string instead of "null"

[patch] Bug 13957: If no value, display an empty string instead of "null"

Bug-13957-If-no-value-display-an-empty-string-inst.patch (text/plain), 1.59 KB, created by Jonathan Druart on 2015-04-07 14:50:07 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: Jonathan Druart

Created: 2015-04-07 14:50:07 UTC

Size: 1.59 KB

patch

obsolete

>From 46b2bb33f99baf64f71d19249bafb89098a36d59 Mon Sep 17 00:00:00 2001
>From: Jonathan Druart <jonathan.druart@biblibre.com>
>Date: Tue, 7 Apr 2015 16:46:27 +0200
>Subject: [PATCH] Bug 13957: If no value, display an empty string instead of
> "null"
>
>Using the autocomplete feature in the patron search, if one value is
>missing (i.e. country), it will be replaced with 'null'.
>The default value should be an empty string.
>
>Test plan:
>0/ Enable the patron autocomplete feature
>1/ Create a patron without value for country
>2/ Go on the circ home page
>3/ Search for this patron. The country should not have been replaced by
>"null".
>---
> circ/ysearch.pl | 14 +++++++-------
> 1 file changed, 7 insertions(+), 7 deletions(-)
>
>diff --git a/circ/ysearch.pl b/circ/ysearch.pl
>index 8e43b8e..ae4ae42 100755
>--- a/circ/ysearch.pl
>+++ b/circ/ysearch.pl
>@@ -71,13 +71,13 @@ my @borrowers;
> while ( my $b = $borrowers_rs->next ) {
>     push @borrowers,
>       { borrowernumber => $b->borrowernumber,
>-        surname        => $b->surname,
>-        firstname      => $b->firstname,
>-        cardnumber     => $b->cardnumber,
>-        address        => $b->address,
>-        city           => $b->city,
>-        zipcode        => $b->zipcode,
>-        country        => $b->country
>+        surname        => $b->surname    // '',
>+        firstname      => $b->firstname  // '',
>+        cardnumber     => $b->cardnumber // '',
>+        address        => $b->address    // '',
>+        city           => $b->city       // '',
>+        zipcode        => $b->zipcode    // '',
>+        country        => $b->country    // '',
>       };
> }
> 
>-- 
>2.1.0

Actions: View | Diff | Splinter Review

Attachments on bug 13957: 37548 | 37549 | 37566 | 37567 | 37666