Attachment 37550 Details for Bug 10388 – Bug 10388: Does not display 'null' after editing an item on receiving

[patch] Bug 10388: Does not display 'null' after editing an item on receiving

Bug-10388-Does-not-display-null-after-editing-an-i.patch (text/plain), 1.49 KB, created by Jonathan Druart on 2015-04-07 15:06:25 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: Jonathan Druart

Created: 2015-04-07 15:06:25 UTC

Size: 1.49 KB

patch

obsolete

>From 13413fd3902c3055772c38073637bd2916ef87ec Mon Sep 17 00:00:00 2001
>From: Jonathan Druart <jonathan.druart@biblibre.com>
>Date: Tue, 7 Apr 2015 17:03:46 +0200
>Subject: [PATCH] Bug 10388: Does not display 'null' after editing an item on
> receiving
>
>After editing an item on receiving, 'null' is displayed if no value is
>defined for a field. It should be blank.
>
>Test plan:
>0/ Set AcqCreateItem to 'ordering'
>1/ Go on the receipt page page
>2/ Edit an item
>3/ Does not fill all values
>4/ Confirm that undefined values are replaced with an empty string
>---
> koha-tmpl/intranet-tmpl/prog/en/modules/acqui/orderreceive.tt | 4 +++-
> 1 file changed, 3 insertions(+), 1 deletion(-)
>
>diff --git a/koha-tmpl/intranet-tmpl/prog/en/modules/acqui/orderreceive.tt b/koha-tmpl/intranet-tmpl/prog/en/modules/acqui/orderreceive.tt
>index 014f39b..08565a6 100644
>--- a/koha-tmpl/intranet-tmpl/prog/en/modules/acqui/orderreceive.tt
>+++ b/koha-tmpl/intranet-tmpl/prog/en/modules/acqui/orderreceive.tt
>@@ -69,7 +69,9 @@
>                             var tds = $("#item_"+itemnumber+" td");
>                             for(var i=2; i<tds.length; i++) {
>                                 var column = items_columns[i];
>-                                $(tds[i]).text(item[column]);
>+                                var text = item[column];
>+                                if ( text == null ) text = '';
>+                                $(tds[i]).text(text);
>                             }
>                         }
>                     );
>-- 
>2.1.0

Actions: View | Diff | Splinter Review

Attachments on bug 10388: 18567 | 37550 | 37672 | 38152