Bugzilla – Attachment 37666 Details for
Bug 13957
Patron autocomplete shows NULL in list of results
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
[PASSED QA] Bug 13957: If no value, display an empty string instead of "null"
PASSED-QA-Bug-13957-If-no-value-display-an-empty-s.patch (text/plain), 1.74 KB, created by
Kyle M Hall (khall)
on 2015-04-10 16:41:28 UTC
(
hide
)
Description:
[PASSED QA] Bug 13957: If no value, display an empty string instead of "null"
Filename:
MIME Type:
Creator:
Kyle M Hall (khall)
Created:
2015-04-10 16:41:28 UTC
Size:
1.74 KB
patch
obsolete
>From f64590207a3de1801d3ba6edf1367bf588253a3b Mon Sep 17 00:00:00 2001 >From: Jonathan Druart <jonathan.druart@biblibre.com> >Date: Tue, 7 Apr 2015 16:46:27 +0200 >Subject: [PATCH] [PASSED QA] Bug 13957: If no value, display an empty string instead of "null" > >Using the autocomplete feature in the patron search, if one value is >missing (i.e. country), it will be replaced with 'null'. >The default value should be an empty string. > >Test plan: >0/ Enable the patron autocomplete feature >1/ Create a patron without value for country, address, zipcode, city >2/ Go on the circ home page >3/ Search for this patron. The country should not have been replaced by >"null". > >Signed-off-by: Nicolas Legrand <nicolas.legrand@bulac.fr> > >Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> >--- > circ/ysearch.pl | 14 +++++++------- > 1 files changed, 7 insertions(+), 7 deletions(-) > >diff --git a/circ/ysearch.pl b/circ/ysearch.pl >index 8e43b8e..ae4ae42 100755 >--- a/circ/ysearch.pl >+++ b/circ/ysearch.pl >@@ -71,13 +71,13 @@ my @borrowers; > while ( my $b = $borrowers_rs->next ) { > push @borrowers, > { borrowernumber => $b->borrowernumber, >- surname => $b->surname, >- firstname => $b->firstname, >- cardnumber => $b->cardnumber, >- address => $b->address, >- city => $b->city, >- zipcode => $b->zipcode, >- country => $b->country >+ surname => $b->surname // '', >+ firstname => $b->firstname // '', >+ cardnumber => $b->cardnumber // '', >+ address => $b->address // '', >+ city => $b->city // '', >+ zipcode => $b->zipcode // '', >+ country => $b->country // '', > }; > } > >-- >1.7.2.5
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 13957
:
37548
|
37549
|
37566
|
37567
| 37666