Attachment 37676 Details for Bug 13975 – Bug 13975: Remove compilation warning about encoding pragma

[patch] Bug 13975: Remove compilation warning about encoding pragma

0001-Bug-13975-Remove-compilation-warning-about-encoding-.patch (text/plain), 1.50 KB, created by Frédéric Demians on 2015-04-11 10:19:27 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: Frédéric Demians

Created: 2015-04-11 10:19:27 UTC

Size: 1.50 KB

patch

obsolete

>From 4037a6895b9176ac501e41845baf87d947c4669c Mon Sep 17 00:00:00 2001
>From: Jonathan Druart <jonathan.druart@biblibre.com>
>Date: Thu, 9 Apr 2015 16:05:59 +0200
>Subject: [PATCH] Bug 13975: Remove compilation warning about encoding pragma
> deprecation
>MIME-Version: 1.0
>Content-Type: text/plain; charset=UTF-8
>Content-Transfer-Encoding: 8bit
>
>Test plan:
>0/ Does not apply the patch
>1/ Launch the export_borrowers.pl script to export data with unicode characters
> % perl misc/export_borrowers.pl -w "borrowernumber=42" --field borrowernumber --field surname --field firstname
>  Use of the encoding pragma is deprecated at misc/export_borrowers.pl
>  7874,JOUBU,ØµØ©ØµØ©ØµØ©
>2/ Apply this patch
>3/ Repeat 1
> % perl misc/export_borrowers.pl -w "borrowernumber=42" --field borrowernumber --field surname --field firstname
>  7874,JOUBU,ØµØ©ØµØ©ØµØ©
>
>Note that the deprecated message is gone and the encoding is correct.
>
>Signed-off-by: Frederic Demians <f.demians@tamil.fr>
>
>  I confirm the warning (on Perl version above 5.14). And that the patch fix
>  the warning.
>---
> misc/export_borrowers.pl | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
>diff --git a/misc/export_borrowers.pl b/misc/export_borrowers.pl
>index 7d3ce47..3063ed1 100755
>--- a/misc/export_borrowers.pl
>+++ b/misc/export_borrowers.pl
>@@ -26,7 +26,7 @@ use Getopt::Long qw(:config no_ignore_case);
> use C4::Context;
> use C4::Members;
> 
>-use encoding 'utf8';
>+binmode STDOUT, ":encoding(UTF-8)";
> 
> sub print_usage {
>     ( my $basename = $0 ) =~ s|.*/||;
>-- 
>2.3.5
>

Actions: View | Diff | Splinter Review

Attachments on bug 13975: 37620 | 37676 | 38034