Bugzilla – Attachment 37708 Details for
Bug 13909
Suspension days calculation doesn't honour finesCalendar
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
Bug 13909: (QA followup) fix references to get_chargeable_units
Bug-13909-QA-followup-fix-references-to-getchargea.patch (text/plain), 1.58 KB, created by
Tomás Cohen Arazi (tcohen)
on 2015-04-12 14:10:51 UTC
(
hide
)
Description:
Bug 13909: (QA followup) fix references to get_chargeable_units
Filename:
MIME Type:
Creator:
Tomás Cohen Arazi (tcohen)
Created:
2015-04-12 14:10:51 UTC
Size:
1.58 KB
patch
obsolete
>From 653686cee9cd3032642933427d86ec9331612607 Mon Sep 17 00:00:00 2001 >From: Tomas Cohen Arazi <tomascohen@gmail.com> >Date: Sun, 12 Apr 2015 10:54:50 -0300 >Subject: [PATCH] Bug 13909: (QA followup) fix references to > get_chargeable_units > >Signed-off-by: Tomas Cohen Arazi <tomascohen@gmail.com> >--- > C4/Circulation.pm | 2 +- > t/db_dependent/Circulation.t | 2 +- > 2 files changed, 2 insertions(+), 2 deletions(-) > >diff --git a/C4/Circulation.pm b/C4/Circulation.pm >index 3baccea..a8c8c08 100644 >--- a/C4/Circulation.pm >+++ b/C4/Circulation.pm >@@ -2142,7 +2142,7 @@ sub _debar_user_on_return { > GetIssuingRule( $borrower->{categorycode}, $item->{itype}, $branchcode ); > my $finedays = $issuingrule->{finedays}; > my $unit = $issuingrule->{lengthunit}; >- my $chargeable_units = get_chargeable_units($unit, $dt_due, $dt_today, $branchcode); >+ my $chargeable_units = C4::Overdues::get_chargeable_units($unit, $dt_due, $dt_today, $branchcode); > > if ($finedays) { > >diff --git a/t/db_dependent/Circulation.t b/t/db_dependent/Circulation.t >index 02d7b00..7396e86 100755 >--- a/t/db_dependent/Circulation.t >+++ b/t/db_dependent/Circulation.t >@@ -450,7 +450,7 @@ C4::Context->dbh->do("DELETE FROM accountlines"); > my $now = dt_from_string(); > my $future = dt_from_string(); > $future->add( days => 7 ); >- my $units = C4::Overdues::_get_chargeable_units('days', $future, $now, 'MPL'); >+ my $units = C4::Overdues::get_chargeable_units('days', $future, $now, 'MPL'); > ok( $units == 0, '_get_chargeable_units returns 0 for items not past due date (Bug 12596)' ); > } > >-- >2.3.5
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 13909
:
37374
|
37598
|
37646
| 37708