Bugzilla – Attachment 37720 Details for
Bug 13982
Checkouts table not sorting on correct column
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
Bug 13982 - Checkouts table not sorting on correct column
Bug-13982---Checkouts-table-not-sorting-on-correct.patch (text/plain), 1.74 KB, created by
Kyle M Hall (khall)
on 2015-04-13 11:05:29 UTC
(
hide
)
Description:
Bug 13982 - Checkouts table not sorting on correct column
Filename:
MIME Type:
Creator:
Kyle M Hall (khall)
Created:
2015-04-13 11:05:29 UTC
Size:
1.74 KB
patch
obsolete
>From cba2d17b25886daf982cb8cbf3dfd2e3da4597a3 Mon Sep 17 00:00:00 2001 >From: Kyle M Hall <kyle@bywatersolutions.com> >Date: Mon, 13 Apr 2015 05:56:24 -0500 >Subject: [PATCH] Bug 13982 - Checkouts table not sorting on correct column > >The "Date Due" column for checkouts is using the column index 1 to sort by. >This column is the one that is used for grouping items into today's checkouts >and previous checkouts. This is definitely not the column that should be used. >Instead, we should be using column index 2, which contains the raw unformatted >due date. > >Test Plan: >1) Find a patron with some checkouts >2) Checkout a new item so it is due between the due dates of two > previously checked out items ( that is, not checked out today ) >3) Attempt to sort by due date >4) Note the sorting is incorrect >5) Apply this patch >6) Clear your browser cache >7) Reload the page >8) Attempt to sort by due date again >9) Note the sorting works correctly this time >10) Verify there are no regressions with bug 13908 >--- > koha-tmpl/intranet-tmpl/prog/en/js/checkouts.js | 2 +- > 1 files changed, 1 insertions(+), 1 deletions(-) > >diff --git a/koha-tmpl/intranet-tmpl/prog/en/js/checkouts.js b/koha-tmpl/intranet-tmpl/prog/en/js/checkouts.js >index 78d2cb7..4d1f966 100644 >--- a/koha-tmpl/intranet-tmpl/prog/en/js/checkouts.js >+++ b/koha-tmpl/intranet-tmpl/prog/en/js/checkouts.js >@@ -191,7 +191,7 @@ $(document).ready(function() { > "bVisible": false, > }, > { >- "iDataSort": 1, // Sort on hidden unformatted date due column >+ "iDataSort": 2, // Sort on hidden unformatted date due column > "mDataProp": function( oObj ) { > var due = oObj.date_due_formatted; > >-- >1.7.2.5
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 13982
:
37720
|
37786
|
38140