Bugzilla – Attachment 37853 Details for
Bug 13813
Remove deprecated module C4::Dates from system - first steps
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
Bug 13813 - Remove deprecated C4::Dates from opac/opac-showreviews.pl
Bug-13813---Remove-deprecated-C4Dates-from-opacopa.patch (text/plain), 1.87 KB, created by
Jonathan Druart
on 2015-04-15 08:12:20 UTC
(
hide
)
Description:
Bug 13813 - Remove deprecated C4::Dates from opac/opac-showreviews.pl
Filename:
MIME Type:
Creator:
Jonathan Druart
Created:
2015-04-15 08:12:20 UTC
Size:
1.87 KB
patch
obsolete
>From 6d21b299524a9dd5304bf3aae896f50cef013051 Mon Sep 17 00:00:00 2001 >From: =?UTF-8?q?Marc=20V=C3=A9ron?= <veron@veron.ch> >Date: Thu, 12 Mar 2015 09:18:17 +0100 >Subject: [PATCH] Bug 13813 - Remove deprecated C4::Dates from > opac/opac-showreviews.pl > >To test: > >This patch removes C4::Dates from opac/opac-showreviews.pl and treats the RSS time stamps the same way as in opac/opac-search.pl > >To test: >- Enable display of 'Recent comments' in OPAC (Syspref OpacShowRecentComments) >- In OPAC, go to Home > Recent comments >- Test RSS feed >- Apply patch >- Test RSS feed again, it should work as before > >Signed-off-by: Jonathan Druart <jonathan.druart@biblibre.com> >--- > opac/opac-showreviews.pl | 9 ++------- > 1 file changed, 2 insertions(+), 7 deletions(-) > >diff --git a/opac/opac-showreviews.pl b/opac/opac-showreviews.pl >index 2bca5d6..e018085 100755 >--- a/opac/opac-showreviews.pl >+++ b/opac/opac-showreviews.pl >@@ -28,7 +28,6 @@ use C4::Output; > use C4::Circulation; > use C4::Review; > use C4::Biblio; >-use C4::Dates; > use C4::Members qw/GetMemberDetails/; > use POSIX qw(ceil strftime); > >@@ -57,11 +56,9 @@ my ( $template, $borrowernumber, $cookie ) = &get_template_and_user( > ); > > if($format eq "rss"){ >- my $lastbuilddate = C4::Dates->new(); >- my $lastbuilddate_output = $lastbuilddate->output("rfc822"); > $template->param( > rss => 1, >- timestamp => $lastbuilddate_output >+ timestamp => strftime("%Y-%m-%dT%H:%M:%S-00:00", gmtime), > ); > } > >@@ -114,9 +111,7 @@ for my $result (@$reviews){ > } > > if($format eq "rss"){ >- my $rsstimestamp = C4::Dates->new($result->{datereviewed},"iso"); >- my $rsstimestamp_output = $rsstimestamp->output("rfc822"); >- $result->{timestamp} = $rsstimestamp_output; >+ $result->{timestamp} = strftime("%Y-%m-%dT%H:%M:%S-00:00", gmtime); > } > } > ## Build the page numbers on the bottom of the page >-- >2.1.0
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 13813
:
36827
|
36828
|
36829
|
36830
|
36831
|
36832
|
36835
|
36836
|
36839
|
36845
|
36850
|
36851
|
36855
|
36857
|
36858
|
36859
|
36862
|
36863
|
36864
|
36865
|
36870
|
36871
|
36872
|
36878
|
36879
|
36880
|
36881
|
36882
|
36883
|
36884
|
36885
|
36886
|
36887
|
36888
|
36889
|
36890
|
36892
|
36893
|
36894
|
36895
|
36896
|
36897
|
36898
|
36899
|
36900
|
36901
|
36902
|
37227
|
37730
|
37731
|
37732
|
37736
|
37737
|
37746
|
37748
|
37749
|
37753
|
37754
|
37757
|
37762
|
37763
|
37764
|
37765
|
37766
|
37767
|
37768
|
37770
|
37810
|
37828
|
37835
|
37839
|
37840
|
37841
|
37842
|
37843
|
37853
|
37854
|
37855
|
37856
|
37857
|
37858
|
37859
|
37860
|
37861
|
37862
|
37863
|
37864
|
37865
|
37866
|
37867
|
37868
|
37869
|
37870
|
37871
|
37872
|
37873
|
37874
|
37875
|
37876
|
37877
|
37878
|
37879
|
37880
|
37881
|
37882
|
37883
|
37884
|
37885
|
37886
|
37887
|
37888
|
37889
|
37890
|
37891
|
39666
|
40894
|
42052
|
42175
|
42274
|
42286
|
42292
|
42293
|
42294