Attachment 37861 Details for Bug 13813 – Bug 13813 - Remove C4::Dates from C4/NewsChannels.pm

[patch] Bug 13813 - Remove C4::Dates from C4/NewsChannels.pm

Bug-13813---Remove-C4Dates-from-C4NewsChannelspm.patch (text/plain), 1.88 KB, created by Jonathan Druart on 2015-04-15 08:12:49 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: Jonathan Druart

Created: 2015-04-15 08:12:49 UTC

Size: 1.88 KB

patch

obsolete

>From 1b248a0e9598790597b49b1651137c43df6bc8bf Mon Sep 17 00:00:00 2001
>From: =?UTF-8?q?Marc=20V=C3=A9ron?= <veron@veron.ch>
>Date: Fri, 13 Mar 2015 17:57:46 +0100
>Subject: [PATCH] Bug 13813 - Remove C4::Dates from C4/NewsChannels.pm
>
>To test:
>Apply patch
>Create some news for OPAC and staff client (Home > Tools > News)
>Verify that dates appear as appropriate
>Verify that Publicaten Date (Creation Date) and Expiration Date work as expected.
>
>Note: Inconsistency in wording for creation date / publication date should be managed in separate Bug 13834
>
>Signed-off-by: Jonathan Druart <jonathan.druart@biblibre.com>
>---
> C4/NewsChannels.pm | 8 ++++----
> 1 file changed, 4 insertions(+), 4 deletions(-)
>
>diff --git a/C4/NewsChannels.pm b/C4/NewsChannels.pm
>index 8694c1b..f7fa1d7 100644
>--- a/C4/NewsChannels.pm
>+++ b/C4/NewsChannels.pm
>@@ -20,7 +20,7 @@ package C4::NewsChannels;
> 
> use Modern::Perl;
> use C4::Context;
>-use C4::Dates qw(format_date);
>+use Koha::DateUtils;
> 
> use vars qw($VERSION @ISA @EXPORT);
> 
>@@ -135,8 +135,8 @@ sub get_opac_new {
>     $sth->execute($idnew);
>     my $data = $sth->fetchrow_hashref;
>     $data->{$data->{'lang'}} = 1 if defined $data->{lang};
>-    $data->{expirationdate} = format_date($data->{expirationdate});
>-    $data->{timestamp}      = format_date($data->{timestamp});
>+    $data->{expirationdate} = output_pref({ dt => dt_from_string( $data->{expirationdate} ), dateonly => 1 });
>+    $data->{timestamp}      = output_pref({ dt => dt_from_string( $data->{timestamp} ), dateonly => 1 }) ;
>     return $data;
> }
> 
>@@ -209,7 +209,7 @@ sub GetNewsToDisplay {
>     $sth->execute($lang,$branch);
>     my @results;
>     while ( my $row = $sth->fetchrow_hashref ){
>-        $row->{newdate} = format_date($row->{newdate});
>+        $row->{newdate} = output_pref({ dt => dt_from_string( $row->{newdate} ), dateonly => 1 });
>         push @results, $row;
>     }
>     return \@results;
>-- 
>2.1.0

Actions: View | Diff | Splinter Review

Attachments on bug 13813: 36827 | 36828 | 36829 | 36830 | 36831 | 36832 | 36835 | 36836 | 36839 | 36845 | 36850 | 36851 | 36855 | 36857 | 36858 | 36859 | 36862 | 36863 | 36864 | 36865 | 36870 | 36871 | 36872 | 36878 | 36879 | 36880 | 36881 | 36882 | 36883 | 36884 | 36885 | 36886 | 36887 | 36888 | 36889 | 36890 | 36892 | 36893 | 36894 | 36895 | 36896 | 36897 | 36898 | 36899 | 36900 | 36901 | 36902 | 37227 | 37730 | 37731 | 37732 | 37736 | 37737 | 37746 | 37748 | 37749 | 37753 | 37754 | 37757 | 37762 | 37763 | 37764 | 37765 | 37766 | 37767 | 37768 | 37770 | 37810 | 37828 | 37835 | 37839 | 37840 | 37841 | 37842 | 37843 | 37853 | 37854 | 37855 | 37856 | 37857 | 37858 | 37859 | 37860 | 37861 | 37862 | 37863 | 37864 | 37865 | 37866 | 37867 | 37868 | 37869 | 37870 | 37871 | 37872 | 37873 | 37874 | 37875 | 37876 | 37877 | 37878 | 37879 | 37880 | 37881 | 37882 | 37883 | 37884 | 37885 | 37886 | 37887 | 37888 | 37889 | 37890 | 37891 | 39666 | 40894 | 42052 | 42175 | 42274 | 42286 | 42292 | 42293 | 42294