Bugzilla – Attachment 37894 Details for
Bug 10181
Improve message shown for deleted records in basket summary page
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
Bug 10181: Acq - Improve message for deleted records
Bug-10181-Acq---Improve-message-for-deleted-record.patch (text/plain), 4.18 KB, created by
Jonathan Druart
on 2015-04-15 09:34:21 UTC
(
hide
)
Description:
Bug 10181: Acq - Improve message for deleted records
Filename:
MIME Type:
Creator:
Jonathan Druart
Created:
2015-04-15 09:34:21 UTC
Size:
4.18 KB
patch
obsolete
>From de287d347dd11c52b71875abe5c67b21b5b9be9c Mon Sep 17 00:00:00 2001 >From: Jonathan Druart <jonathan.druart@biblibre.com> >Date: Wed, 15 Apr 2015 11:30:17 +0200 >Subject: [PATCH] Bug 10181: Acq - Improve message for deleted records > >There are some issues here: >1/ Message not translatable (set in the pl file) >2/ ' by 'displayed even if no author defined >3/ Message not the same every where >4/ Nothing displayed on the invoice page > >Test plan: >1/ Create a basket >2/ Add 4 orders A, B, C, D >3/ On the basket, you see "$title by $author", or "$title" if no author >defined >4/ Delete order A, B >5/ Close the basket >6/ Receive B, C >7/ Delete record created for A, C >8/ Go on the basket page, you should see the title and "Deleted >bibliographic record, can't find title" for the deleted record >9/ Go on the invoice page, you should see the title and "Deleted >bibliographic record, can't find title" for the deleted record >--- > koha-tmpl/intranet-tmpl/prog/en/modules/acqui/basket.tt | 7 ++++--- > koha-tmpl/intranet-tmpl/prog/en/modules/acqui/invoice.tt | 10 +++++++--- > 2 files changed, 11 insertions(+), 6 deletions(-) > >diff --git a/koha-tmpl/intranet-tmpl/prog/en/modules/acqui/basket.tt b/koha-tmpl/intranet-tmpl/prog/en/modules/acqui/basket.tt >index 98a45b5..536af80 100644 >--- a/koha-tmpl/intranet-tmpl/prog/en/modules/acqui/basket.tt >+++ b/koha-tmpl/intranet-tmpl/prog/en/modules/acqui/basket.tt >@@ -462,7 +462,7 @@ > <p> > [% IF ( books_loo.order_received ) %] (rcvd)[% END %] > [% IF books_loo.title %] >- <a href="/cgi-bin/koha/catalogue/detail.pl?biblionumber=[% books_loo.biblionumber %]">[% books_loo.title |html %]</a> by [% books_loo.author %] >+ <a href="/cgi-bin/koha/catalogue/detail.pl?biblionumber=[% books_loo.biblionumber %]">[% books_loo.title |html %]</a>[% IF books_loo.author %] by [% books_loo.author %][% END %] > [% ELSE %] > <em>Deleted bibliographic record, can't find title</em><br /> > [% END %] >@@ -586,10 +586,11 @@ > <p> > [% IF ( order.order_received ) %] (rcvd)[% END %] > [% IF (order.title) %] >- [% order.title |html %] by [% order.author %]<br /> >+ [% order.title |html %][% IF order.author %] by [% order.author %][% END %] > [% ELSE %] >- <em>Deleted bibliographic record, can't find title</em><br /> >+ <em>Deleted bibliographic record, can't find title</em> > [% END %] >+ <br /> > [% IF ( order.order_internalnote ) %] [% order.order_internalnote %][% END %] > [% IF ( order.isbn ) %] - [% order.isbn %][% END %] > [% IF ( order.issn ) %] - [% order.issn %][% END %] >diff --git a/koha-tmpl/intranet-tmpl/prog/en/modules/acqui/invoice.tt b/koha-tmpl/intranet-tmpl/prog/en/modules/acqui/invoice.tt >index ce278d4..153a8fc 100644 >--- a/koha-tmpl/intranet-tmpl/prog/en/modules/acqui/invoice.tt >+++ b/koha-tmpl/intranet-tmpl/prog/en/modules/acqui/invoice.tt >@@ -147,9 +147,13 @@ > [% FOREACH order IN orders_loop %] > <tr> > <td> >- <a href="/cgi-bin/koha/catalogue/detail.pl?biblionumber=[% order.biblionumber %]">[% order.title %]</a> >- [% IF ( order.author ) %] >- <br /><em>by</em> [% order.author %] >+ [% IF order.biblionumber %] >+ <a href="/cgi-bin/koha/catalogue/detail.pl?biblionumber=[% order.biblionumber %]">[% order.title %]</a> >+ [% IF ( order.author ) %] >+ <br /><em>by</em> [% order.author %] >+ [% END %] >+ [% ELSE %] >+ <em>Deleted bibliographic record, can't find title</em> > [% END %] > [% IF ( order.publishercode ) %] > <br/>[% order.publishercode %] >-- >2.1.0
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 10181
:
37894
|
42070
|
42071
|
42098
|
42099
|
42721
|
42722
|
42985
|
42986