Attachment 37964 Details for Bug 10355 – Bug 10355: paramater 'object' lost on the road

[patch] Bug 10355: paramater 'object' lost on the road

Bug-10355-paramater-object-lost-on-the-road.patch (text/plain), 2.47 KB, created by Jonathan Druart on 2015-04-16 14:41:13 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: Jonathan Druart

Created: 2015-04-16 14:41:13 UTC

Size: 2.47 KB

patch

obsolete

>From 7bd5f714c8430368de770ea310dc9bcace2744de Mon Sep 17 00:00:00 2001
>From: Jonathan Druart <jonathan.druart@biblibre.com>
>Date: Thu, 16 Apr 2015 16:39:09 +0200
>Subject: [PATCH] Bug 10355: paramater 'object' lost on the road
>
>Test plan:
>1) Go to any detail page in staff
>2) Click on the modification log tab
>3) Verify, that the object is prefilled with the records biblionumber
>and you can also see it as parameter in the url
>4) Click a second time on modification log to reset your search
>
>Before this patch, the object parameter was empty.
>It now contains the value of the biblionumber.
>---
> koha-tmpl/intranet-tmpl/prog/en/includes/biblio-view-menu.inc | 2 +-
> tools/viewlog.pl                                              | 2 +-
> 2 files changed, 2 insertions(+), 2 deletions(-)
>
>diff --git a/koha-tmpl/intranet-tmpl/prog/en/includes/biblio-view-menu.inc b/koha-tmpl/intranet-tmpl/prog/en/includes/biblio-view-menu.inc
>index b2edbe6..8d9ceec 100644
>--- a/koha-tmpl/intranet-tmpl/prog/en/includes/biblio-view-menu.inc
>+++ b/koha-tmpl/intranet-tmpl/prog/en/includes/biblio-view-menu.inc
>@@ -30,7 +30,7 @@
> <ul>
> [% IF ( issuehistoryview ) %]<li class="active">[% ELSE %]<li>[% END %]
> <a href="/cgi-bin/koha/catalogue/issuehistory.pl?biblionumber=[% IF ( object ) %][% object %][% ELSE %][% IF ( object ) %][% object %][% ELSE %][% biblionumber %][% END %][% END %]" >Checkout history</a></li>
>-[% IF ( CAN_user_tools_view_system_logs ) %][% IF ( logview ) %]<li class="active">[% ELSE %]<li>[% END %]<a href="/cgi-bin/koha/tools/viewlog.pl?do_it=1&amp;modules=CATALOGUING&amp;action=MODIFY&amp;object=[% biblionumber %]">Modification log</a> </li>[% END %]
>+[% IF ( CAN_user_tools_view_system_logs ) %][% IF ( logview ) %]<li class="active">[% ELSE %]<li>[% END %]<a href="/cgi-bin/koha/tools/viewlog.pl?do_it=1&amp;modules=CATALOGUING&amp;action=MODIFY&amp;object=[% biblionumber or object %]">Modification log</a> </li>[% END %]
> </ul>
> </div>
> 
>diff --git a/tools/viewlog.pl b/tools/viewlog.pl
>index c867226..9a6ffc0 100755
>--- a/tools/viewlog.pl
>+++ b/tools/viewlog.pl
>@@ -121,6 +121,7 @@ if ( $src eq 'circ' ) {
> $template->param(
>     debug => $debug,
>     C4::Search::enabled_staff_search_views,
>+    object => $object,
> );
> 
> if ($do_it) {
>@@ -187,7 +188,6 @@ if ($do_it) {
>             datefrom => $datefrom,
>             dateto   => $dateto,
>             user     => $user,
>-            object   => $object,
>             info     => $info,
>             src      => $src,
>             modules  => \@modules,
>-- 
>2.1.0

Actions: View | Diff | Splinter Review

Attachments on bug 10355: 37964 | 39259 | 39717