Bugzilla – Attachment 37980 Details for
Bug 13991
Uninitialized value $src in /tools/viewlog.pl
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
Bug 13991: (QA followup) uninitialized value and [0] in /tools/viewlog.pl
Bug-13991-QA-followup-uninitialized-value-and-0-in.patch (text/plain), 1.34 KB, created by
Tomás Cohen Arazi (tcohen)
on 2015-04-16 16:55:35 UTC
(
hide
)
Description:
Bug 13991: (QA followup) uninitialized value and [0] in /tools/viewlog.pl
Filename:
MIME Type:
Creator:
Tomás Cohen Arazi (tcohen)
Created:
2015-04-16 16:55:35 UTC
Size:
1.34 KB
patch
obsolete
>From 4dd391ef070041996b4d6935cebae6e7f93e791d Mon Sep 17 00:00:00 2001 >From: Tomas Cohen Arazi <tomascohen@gmail.com> >Date: Thu, 16 Apr 2015 13:55:05 -0300 >Subject: [PATCH] Bug 13991: (QA followup) uninitialized value and [0] in > /tools/viewlog.pl > >Signed-off-by: Tomas Cohen Arazi <tomascohen@gmail.com> >--- > tools/viewlog.pl | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > >diff --git a/tools/viewlog.pl b/tools/viewlog.pl >index 4e772d0..ed38a7a 100755 >--- a/tools/viewlog.pl >+++ b/tools/viewlog.pl >@@ -46,7 +46,7 @@ my $input = new CGI; > $debug or $debug = $cgi_debug; > my $do_it = $input->param('do_it'); > my @modules = $input->param("modules"); >-my $user = $input->param("user"); >+my $user = $input->param("user") // ''; > my @actions = $input->param("actions"); > my $object = $input->param("object"); > my $info = $input->param("info"); >@@ -127,7 +127,7 @@ if ($do_it) { > > my @data; > my ( $results, $modules, $actions ); >- if ( $actions[0] ne '' ) { $actions = \@actions; } # match All means no limit >+ if ( defined $actions[0] && $actions[0] ne '' ) { $actions = \@actions; } # match All means no limit > if ( $modules[0] ne '' ) { $modules = \@modules; } # match All means no limit > $results = GetLogs( $datefrom, $dateto, $user, $modules, $actions, $object, $info ); > @data = @$results; >-- >2.3.5
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 13991
:
37791
|
37802
|
37922
| 37980