Bugzilla – Attachment 37995 Details for
Bug 8399
Problems with mandatory field alert message for authorities
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
[PASSED QA] Bug 8399: No need to truncate the marc field text to 22 chars
PASSED-QA-Bug-8399-No-need-to-truncate-the-marc-fi.patch (text/plain), 5.93 KB, created by
Katrin Fischer
on 2015-04-17 06:16:14 UTC
(
hide
)
Description:
[PASSED QA] Bug 8399: No need to truncate the marc field text to 22 chars
Filename:
MIME Type:
Creator:
Katrin Fischer
Created:
2015-04-17 06:16:14 UTC
Size:
5.93 KB
patch
obsolete
>From fbf14c6b69ee57f55e30e2fc81c30e78b01fb872 Mon Sep 17 00:00:00 2001 >From: Jonathan Druart <jonathan.druart@biblibre.com> >Date: Tue, 14 Apr 2015 11:23:21 +0200 >Subject: [PATCH] [PASSED QA] Bug 8399: No need to truncate the marc field text > to 22 chars >MIME-Version: 1.0 >Content-Type: text/plain; charset=UTF-8 >Content-Transfer-Encoding: 8bit > >The text for the marc field are truncated to 22 chars when displaying an >error on mandatory fields. >This limitation is useless and this patch removes it. > >Test plan: >Create a mandatory subfield and set a long text (more than 22 chars) >edit or add an authority, click on save. >You should get the error displayed with the full text > >Note that this patch modifies the same code for biblio. >Test plan is the same for biblio. > >Signed-off-by: Andreas Hedström Mace <andreas.hedstrom.mace@sub.su.se> > >Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> >--- > authorities/authorities.pl | 3 +-- > cataloguing/addbiblio.pl | 3 +-- > koha-tmpl/intranet-tmpl/prog/en/modules/authorities/authorities.tt | 4 ++-- > koha-tmpl/intranet-tmpl/prog/en/modules/cataloguing/addbiblio.tt | 4 ++-- > 4 files changed, 6 insertions(+), 8 deletions(-) > >diff --git a/authorities/authorities.pl b/authorities/authorities.pl >index 88eb156..bb98d82 100755 >--- a/authorities/authorities.pl >+++ b/authorities/authorities.pl >@@ -175,8 +175,7 @@ sub create_input { > my %subfield_data = ( > tag => $tag, > subfield => $id_subfield, >- marc_lib => substr( $tagslib->{$tag}->{$subfield}->{lib}, 0, 22 ), >- marc_lib_plain => $tagslib->{$tag}->{$subfield}->{lib}, >+ marc_lib => $tagslib->{$tag}->{$subfield}->{lib}, > tag_mandatory => $tagslib->{$tag}->{mandatory}, > mandatory => $tagslib->{$tag}->{$subfield}->{mandatory}, > repeatable => $tagslib->{$tag}->{$subfield}->{repeatable}, >diff --git a/cataloguing/addbiblio.pl b/cataloguing/addbiblio.pl >index ecc87f2..23de063 100755 >--- a/cataloguing/addbiblio.pl >+++ b/cataloguing/addbiblio.pl >@@ -322,8 +322,7 @@ sub create_input { > my %subfield_data = ( > tag => $tag, > subfield => $id_subfield, >- marc_lib => substr( $tagslib->{$tag}->{$subfield}->{lib}, 0, 22 ), >- marc_lib_plain => $tagslib->{$tag}->{$subfield}->{lib}, >+ marc_lib => $tagslib->{$tag}->{$subfield}->{lib}, > tag_mandatory => $tagslib->{$tag}->{mandatory}, > mandatory => $tagslib->{$tag}->{$subfield}->{mandatory}, > repeatable => $tagslib->{$tag}->{$subfield}->{repeatable}, >diff --git a/koha-tmpl/intranet-tmpl/prog/en/modules/authorities/authorities.tt b/koha-tmpl/intranet-tmpl/prog/en/modules/authorities/authorities.tt >index 31939b4..de0d2ab 100644 >--- a/koha-tmpl/intranet-tmpl/prog/en/modules/authorities/authorities.tt >+++ b/koha-tmpl/intranet-tmpl/prog/en/modules/authorities/authorities.tt >@@ -319,7 +319,7 @@ function confirmnotdup(redirect){ > <img class="buttonUp" src="[% interface %]/[% theme %]/img/up.png" onclick="upSubfield('subfield[% subfield_loo.tag %][% subfield_loo.subfield %][% subfield_loo.random %]')" alt="Move Up" title="Move Up" /> > [% END %] > <input type="text" >- title="[% subfield_loo.marc_lib_plain %]" >+ title="[% subfield_loo.marc_lib %]" > style=" [% IF ( subfield_loo.fixedfield ) %]display:none; [% END %]border:0;" > name="tag_[% subfield_loo.tag %]_code_[% subfield_loo.subfield %]_[% subfield_loo.index %]_[% subfield_loo.index_subfield %]" > value="[% subfield_loo.subfield %]" >@@ -336,7 +336,7 @@ function confirmnotdup(redirect){ > > [% UNLESS advancedMARCEditor %] > [% IF ( subfield_loo.mandatory ) %]<span class="subfield subfield_mandatory">[% ELSE %]<span class="subfield">[% END %] >- [% subfield_loo.marc_lib_plain %] >+ [% subfield_loo.marc_lib %] > [% IF ( subfield_loo.mandatory ) %]<span class="mandatory_marker" title="This field is mandatory">*</span>[% END %] > </span> > </label> >diff --git a/koha-tmpl/intranet-tmpl/prog/en/modules/cataloguing/addbiblio.tt b/koha-tmpl/intranet-tmpl/prog/en/modules/cataloguing/addbiblio.tt >index 7c6b48d..3bc00d5 100644 >--- a/koha-tmpl/intranet-tmpl/prog/en/modules/cataloguing/addbiblio.tt >+++ b/koha-tmpl/intranet-tmpl/prog/en/modules/cataloguing/addbiblio.tt >@@ -597,7 +597,7 @@ function Changefwk(FwkList) { > <img class="buttonUp" src="[% interface %]/[% theme %]/img/up.png" onclick="upSubfield('subfield[% subfield_loo.tag %][% subfield_loo.subfield %][% subfield_loo.random %]')" alt="Move Up" title="Move Up" /> > [% END %] > <input type="text" >- title="[% subfield_loo.marc_lib_plain %]" >+ title="[% subfield_loo.marc_lib %]" > style=" [% IF ( subfield_loo.fixedfield ) %]display:none; [% END %]border:0;" > name="tag_[% subfield_loo.tag %]_code_[% subfield_loo.subfield %]_[% subfield_loo.index %]_[% subfield_loo.index_subfield %]" > value="[% subfield_loo.subfield %]" >@@ -609,7 +609,7 @@ function Changefwk(FwkList) { > > [% UNLESS advancedMARCEditor %] > [% IF ( subfield_loo.mandatory ) %]<span class="subfield subfield_mandatory">[% ELSE %]<span class="subfield">[% END %] >- [% subfield_loo.marc_lib_plain %] >+ [% subfield_loo.marc_lib %] > [% IF ( subfield_loo.mandatory ) %]<span class="mandatory_marker" title="This field is mandatory">*</span>[% END %] > </span> > </label> >-- >1.9.1
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 8399
:
10725
|
37405
|
37795
|
37800
|
37804
| 37995 |
37996