Bugzilla – Attachment 37996 Details for
Bug 8399
Problems with mandatory field alert message for authorities
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
[PASSED QA] Bug 8399: Display tab number on the mandatory field alert (authority)
PASSED-QA-Bug-8399-Display-tab-number-on-the-manda.patch (text/plain), 1.72 KB, created by
Katrin Fischer
on 2015-04-17 06:16:27 UTC
(
hide
)
Description:
[PASSED QA] Bug 8399: Display tab number on the mandatory field alert (authority)
Filename:
MIME Type:
Creator:
Katrin Fischer
Created:
2015-04-17 06:16:27 UTC
Size:
1.72 KB
patch
obsolete
>From 17e06238d3087b857198971e0fc0e5b4276f22f8 Mon Sep 17 00:00:00 2001 >From: Jonathan Druart <jonathan.druart@biblibre.com> >Date: Tue, 31 Mar 2015 15:29:49 +0200 >Subject: [PATCH] [PASSED QA] Bug 8399: Display tab number on the mandatory > field alert (authority) >MIME-Version: 1.0 >Content-Type: text/plain; charset=UTF-8 >Content-Transfer-Encoding: 8bit > >A wrong variable scope was used here, the number value is contained in >the BIG_LOOP (note for later: change this variable name...). > >Test plan: >1/ Define 1+ mandatory fields for an authority type >2/ Create an authority and don't fill the mandatory fields >3/ Try to save: the popup alert should display the number of the tab. > >Signed-off-by: Andreas Hedström Mace <andreas.hedstrom.mace@sub.su.se> > >Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> >--- > koha-tmpl/intranet-tmpl/prog/en/modules/authorities/authorities.tt | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > >diff --git a/koha-tmpl/intranet-tmpl/prog/en/modules/authorities/authorities.tt b/koha-tmpl/intranet-tmpl/prog/en/modules/authorities/authorities.tt >index de0d2ab..d6b3a2e 100644 >--- a/koha-tmpl/intranet-tmpl/prog/en/modules/authorities/authorities.tt >+++ b/koha-tmpl/intranet-tmpl/prog/en/modules/authorities/authorities.tt >@@ -62,7 +62,7 @@ function AreMandatoriesNotOk(){ > [% END %] > [% FOREACH subfield_loo IN innerloo.subfield_loop %] > [% IF ( subfield_loo.mandatory ) %]mandatories.push("[% subfield_loo.id %]"); >- tab.push("[% subfield_loo.number %]"); >+ tab.push("[% BIG_LOO.number %]"); > label.push("[% subfield_loo.marc_lib |replace("'", "\'") |replace('"', '\"') |replace('\n', '\\n') |replace('\r', '\\r') %]"); > [% END %] > [% END %] >-- >1.9.1
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 8399
:
10725
|
37405
|
37795
|
37800
|
37804
|
37995
| 37996