Bugzilla – Attachment 38019 Details for
Bug 13364
Add a call number browser to add item page
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
Bug 13364: Use SQL placeholder
Bug-13364-Use-SQL-placeholder.patch (text/plain), 1.28 KB, created by
Jonathan Druart
on 2015-04-17 10:07:32 UTC
(
hide
)
Description:
Bug 13364: Use SQL placeholder
Filename:
MIME Type:
Creator:
Jonathan Druart
Created:
2015-04-17 10:07:32 UTC
Size:
1.28 KB
patch
obsolete
>From 2be7e751790881cb8447c82b7e7fb4305b29a879 Mon Sep 17 00:00:00 2001 >From: Jonathan Druart <jonathan.druart@biblibre.com> >Date: Fri, 17 Apr 2015 12:06:49 +0200 >Subject: [PATCH] Bug 13364: Use SQL placeholder > >--- > cataloguing/value_builder/cn_browser.pl | 5 ++--- > 1 file changed, 2 insertions(+), 3 deletions(-) > >diff --git a/cataloguing/value_builder/cn_browser.pl b/cataloguing/value_builder/cn_browser.pl >index 44a65df..9aa2631 100755 >--- a/cataloguing/value_builder/cn_browser.pl >+++ b/cataloguing/value_builder/cn_browser.pl >@@ -82,12 +82,12 @@ sub plugin { > FROM items AS i > JOIN biblio AS b USING (biblionumber) > LEFT OUTER JOIN branches ON (branches.branchcode = homebranch) >- WHERE cn_sort < '$cn_sort' >+ WHERE cn_sort < ? > AND itemcallnumber != '' > ORDER BY cn_sort DESC, itemnumber > LIMIT $real_limit;"; > $sth = $dbh->prepare($query); >- $sth->execute(); >+ $sth->execute($cn_sort); > while ( my $data = $sth->fetchrow_hashref ) { > if ( $data->{itemcallnumber} eq $q ) { > $data->{background} = 'red'; >@@ -102,7 +102,6 @@ sub plugin { > unshift @cn, $data; > } > $rows_lt = $sth->rows; >- $sth->finish; > } > > if ( $search ne $lt ) { >-- >2.1.0
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 13364
:
34041
|
34108
|
34109
|
34476
|
34540
|
34541
|
34542
|
34543
|
34586
|
34587
|
34588
|
34589
|
35067
|
35549
|
36194
|
36235
|
36249
|
36431
|
36596
|
36597
|
36598
|
36599
|
36600
|
36601
|
36723
|
36782
|
37192
|
37193
|
37194
|
37195
|
38010
|
38011
|
38018
| 38019 |
38894