Attachment 38034 Details for Bug 13975 – Bug 13975: Remove compilation warning about encoding pragma

[patch] Bug 13975: Remove compilation warning about encoding pragma

0001-PASSED-QA-Bug-13975-Remove-compilation-warning-about.patch (text/plain), 1.57 KB, created by Kyle M Hall (khall) on 2015-04-17 11:12:14 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: Kyle M Hall (khall)

Created: 2015-04-17 11:12:14 UTC

Size: 1.57 KB

patch

obsolete

>From 61a3b7a6dc563f2528aace04d961757af4016101 Mon Sep 17 00:00:00 2001
>From: Jonathan Druart <jonathan.druart@biblibre.com>
>Date: Thu, 9 Apr 2015 16:05:59 +0200
>Subject: [PATCH] [PASSED QA] Bug 13975: Remove compilation warning about encoding pragma deprecation
>MIME-Version: 1.0
>Content-Type: text/plain; charset=UTF-8
>Content-Transfer-Encoding: 8bit
>
>Test plan:
>0/ Does not apply the patch
>1/ Launch the export_borrowers.pl script to export data with unicode characters
> % perl misc/export_borrowers.pl -w "borrowernumber=42" --field borrowernumber --field surname --field firstname
>  Use of the encoding pragma is deprecated at misc/export_borrowers.pl
>  7874,JOUBU,ØµØ©ØµØ©ØµØ©
>2/ Apply this patch
>3/ Repeat 1
> % perl misc/export_borrowers.pl -w "borrowernumber=42" --field borrowernumber --field surname --field firstname
>  7874,JOUBU,ØµØ©ØµØ©ØµØ©
>
>Note that the deprecated message is gone and the encoding is correct.
>
>Signed-off-by: Frederic Demians <f.demians@tamil.fr>
>
>  I confirm the warning (on Perl version above 5.14). And that the patch fix
>  the warning.
>
>Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com>
>---
> misc/export_borrowers.pl |    2 +-
> 1 files changed, 1 insertions(+), 1 deletions(-)
>
>diff --git a/misc/export_borrowers.pl b/misc/export_borrowers.pl
>index 7d3ce47..3063ed1 100755
>--- a/misc/export_borrowers.pl
>+++ b/misc/export_borrowers.pl
>@@ -26,7 +26,7 @@ use Getopt::Long qw(:config no_ignore_case);
> use C4::Context;
> use C4::Members;
> 
>-use encoding 'utf8';
>+binmode STDOUT, ":encoding(UTF-8)";
> 
> sub print_usage {
>     ( my $basename = $0 ) =~ s|.*/||;
>-- 
>1.7.2.5
>

Actions: View | Diff | Splinter Review

Attachments on bug 13975: 37620 | 37676 | 38034