Attachment 38035 Details for Bug 13819 – [PASSED QA] Add biblioitems to ISSUESLIP and ISSUEQSLIP in C4::Members::IssueSlip()

[patch] [PASSED QA] Add biblioitems to ISSUESLIP and ISSUEQSLIP in C4::Members::IssueSlip()

PASSED-QA-Add-biblioitems-to-ISSUESLIP-and-ISSUEQS.patch (text/plain), 2.92 KB, created by Kyle M Hall (khall) on 2015-04-17 11:23:51 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: Kyle M Hall (khall)

Created: 2015-04-17 11:23:51 UTC

Size: 2.92 KB

patch

obsolete

>From 662d29948510a13337f4bdc8c05b9c78805df1f5 Mon Sep 17 00:00:00 2001
>From: Barton <barton@bywatersolutions.com>
>Date: Wed, 11 Mar 2015 22:53:11 +0000
>Subject: [PATCH] [PASSED QA] Add biblioitems to ISSUESLIP and ISSUEQSLIP in C4::Members::IssueSlip()
>
>Document all expansions within  C4::Members::IssueSlip()
>
>http://bugs.koha-community.org/show_bug.cgi?id=13819
>
>Signed-off-by: Frederic Demians <f.demians@tamil.fr>
>  - Works as described. ISBN appears on ISSUESLIP & ISSUEQSLIP.
>
>Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com>
>  - Not all fields for biblioitems are available, but neither
>    are they all available for other tables. Noted in POD.
>---
> C4/Members.pm |   57 ++++++++++++++++++++++++++++++++++++++++++++++++---------
> 1 files changed, 48 insertions(+), 9 deletions(-)
>
>diff --git a/C4/Members.pm b/C4/Members.pm
>index 4ca83b9..89a208b 100644
>--- a/C4/Members.pm
>+++ b/C4/Members.pm
>@@ -2434,6 +2434,42 @@ sub DeleteMessage {
> 
>   $quickslip is boolean, to indicate whether we want a quick slip
> 
>+  IssueSlip populates ISSUESLIP and ISSUEQSLIP, and will make the following expansions:
>+
>+  Both slips:
>+
>+      <<branches.*>>
>+      <<borrowers.*>>
>+
>+  ISSUESLIP:
>+
>+      <checkedout>
>+         <<biblio.*>>
>+         <<items.*>>
>+         <<biblioitems.*>>
>+         <<issues.*>>
>+      </checkedout>
>+
>+      <overdue>
>+         <<biblio.*>>
>+         <<items.*>>
>+         <<biblioitems.*>>
>+         <<issues.*>>
>+      </overdue>
>+
>+      <news>
>+         <<opac_news.*>>
>+      </news>
>+
>+  ISSUEQSLIP:
>+
>+      <checkedout>
>+         <<biblio.*>>
>+         <<items.*>>
>+         <<biblioitems.*>>
>+         <<issues.*>>
>+      </checkedout>
>+
> =cut
> 
> sub IssueSlip {
>@@ -2461,9 +2497,10 @@ sub IssueSlip {
>         $letter_code = 'ISSUEQSLIP';
>         %repeat =  (
>             'checkedout' => [ map {
>-                'biblio' => $_,
>-                'items'  => $_,
>-                'issues' => $_,
>+                'biblio'       => $_,
>+                'items'        => $_,
>+                'biblioitems'  => $_,
>+                'issues'       => $_,
>             }, grep { $_->{'now'} } @issues ],
>         );
>     }
>@@ -2471,15 +2508,17 @@ sub IssueSlip {
>         $letter_code = 'ISSUESLIP';
>         %repeat =  (
>             'checkedout' => [ map {
>-                'biblio' => $_,
>-                'items'  => $_,
>-                'issues' => $_,
>+                'biblio'       => $_,
>+                'items'        => $_,
>+                'biblioitems'  => $_,
>+                'issues'       => $_,
>             }, grep { !$_->{'overdue'} } @issues ],
> 
>             'overdue' => [ map {
>-                'biblio' => $_,
>-                'items'  => $_,
>-                'issues' => $_,
>+                'biblio'       => $_,
>+                'items'        => $_,
>+                'biblioitems'  => $_,
>+                'issues'       => $_,
>             }, grep { $_->{'overdue'} } @issues ],
> 
>             'news' => [ map {
>-- 
>1.7.2.5

Actions: View | Diff | Splinter Review

Attachments on bug 13819: 36824 | 36927 | 37677 | 38035 | 38036