Attachment 38062 Details for Bug 14008 – Bug 14008: Display active filters when searching for reports

[patch] Bug 14008: Display active filters when searching for reports

Bug-14008-Display-active-filters-when-searching-fo.patch (text/plain), 3.25 KB, created by Jonathan Druart on 2015-04-17 13:28:26 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: Jonathan Druart

Created: 2015-04-17 13:28:26 UTC

Size: 3.25 KB

patch

obsolete

>From 7cb85b4146194bb6237034a00fec19707e883b54 Mon Sep 17 00:00:00 2001
>From: Jonathan Druart <jonathan.druart@biblibre.com>
>Date: Fri, 17 Apr 2015 15:24:36 +0200
>Subject: [PATCH] Bug 14008: Display active filters when searching for reports
>
>On the saved report list, the filters on the left are not displayed.
>It means that some can be set, but the user has not visible feedbacks.
>
>How filters work here:
>If a user set a filter, it is saved in the session. Next time he will
>come on this search, the previous values will be kept.
>
>This patch just displayed the filter's values in the input fields.
>
>Test plan:
>Search for reports by date, author and keyword.
>The filters should be displayed after you have clicked on the submit
>button ("Apply filter").
>---
> .../prog/en/modules/reports/guided_reports_start.tt              | 9 +++------
> reports/guided_reports.pl                                        | 1 +
> 2 files changed, 4 insertions(+), 6 deletions(-)
>
>diff --git a/koha-tmpl/intranet-tmpl/prog/en/modules/reports/guided_reports_start.tt b/koha-tmpl/intranet-tmpl/prog/en/modules/reports/guided_reports_start.tt
>index d2420a0..98cc1ff 100644
>--- a/koha-tmpl/intranet-tmpl/prog/en/modules/reports/guided_reports_start.tt
>+++ b/koha-tmpl/intranet-tmpl/prog/en/modules/reports/guided_reports_start.tt
>@@ -167,9 +167,6 @@ $(document).ready(function(){
>         }
>     });
> [% END %]
>-  // redefine the datepicker's default because reports require ISO
>-  // http://jqueryui.com/demos/datepicker/#option-dateFormat
>-  $( ".datepicker" ).datepicker( "option", "dateFormat", "yy-mm-dd" );
> 
> [% IF (create || editsql || save) %]
>     $("#select_group").change(function() {
>@@ -1025,12 +1022,12 @@ Sub report:<select name="subreport">
>   <fieldset class="brief">
>   <h3>Filter</h3>
>   <ol>
>-    <li><label for="filter_date">Date:</label> <input type="text" id="filter_date" name="filter_date" size="10" value="[% filter_date %]" class="datepicker" />
>+    <li><label for="filter_date">Date:</label> <input type="text" id="filter_date" name="filter_date" size="10" value="[% filters.date %]" class="datepicker" />
>     <div class="hint">[% INCLUDE 'date-format.inc' %]</div>
> 
>     </li>
>-    <li><label for="filter_author">Author:</label> <input type="text" id="filter_author" name="filter_author" value="[% filter_author %]" /></li>
>-    <li><label for="filter_keyword">Keyword:</label> <input type="text" id="filter_keyword" name="filter_keyword" value="[% filter_keyword %]" /></li>
>+    <li><label for="filter_author">Author:</label> <input type="text" id="filter_author" name="filter_author" value="[% filters.author %]" /></li>
>+    <li><label for="filter_keyword">Keyword:</label> <input type="text" id="filter_keyword" name="filter_keyword" value="[% filters.keyword %]" /></li>
>   </ol>
>   </fieldset>
>   <fieldset class="action"><input type="submit" value="Apply filter" /></fieldset>
>diff --git a/reports/guided_reports.pl b/reports/guided_reports.pl
>index a3009b2..435e53e 100755
>--- a/reports/guided_reports.pl
>+++ b/reports/guided_reports.pl
>@@ -107,6 +107,7 @@ elsif ( $phase eq 'Build new' ) {
>         'savedreports' => get_saved_reports($filter),
>         'usecache' => $usecache,
>         'groups_with_subgroups'=> groups_with_subgroups($group, $subgroup),
>+        filters => $filter,
>     );
> }
> 
>-- 
>2.1.0

Actions: View | Diff | Splinter Review

Attachments on bug 14008: 38062 | 38125 | 38136 | 38137 | 38211 | 38212