Attachment 38143 Details for Bug 13623 – [PASSED QA] Bug 13623 - Enhance html for holds queue viewer

[patch] [PASSED QA] Bug 13623 - Enhance html for holds queue viewer

PASSED-QA-Bug-13623---Enhance-html-for-holds-queue.patch (text/plain), 4.49 KB, created by Katrin Fischer on 2015-04-19 20:58:34 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: Katrin Fischer

Created: 2015-04-19 20:58:34 UTC

Size: 4.49 KB

patch

obsolete

>From 57f0c396cfb1eb10f5e80aa695a62f4b161bbec3 Mon Sep 17 00:00:00 2001
>From: ByWater Staff <staff@bywatersolutions.com>
>Date: Mon, 26 Jan 2015 10:16:42 -0600
>Subject: [PATCH] [PASSED QA] Bug 13623 - Enhance html for holds queue viewer
>MIME-Version: 1.0
>Content-Type: text/plain; charset=UTF-8
>Content-Transfer-Encoding: 8bit
>
>It would be very helpful from a css/scripting point of view if the
>author field in the holds queue report had a selectable class. In
>edition, it would be great if the biblionumber were easy to grab from a
>hidden div.
>
>Test Plan:
>1) Apply this patch
>2) Load the holds queue report ( view_holdsqueue.pl )
>3) Inspect an author name with your web browser ( or view the html )
>   a) Note the hq-author class of the wrapping div
>   b) Note the hidden hq-biblionumber div
>
>HTML appears as expected.
>Signed-off-by: Marc VÃ©ron <veron@veron.ch>
>
>Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de>
>---
> .../intranet-tmpl/prog/en/css/staff-global.css     |  4 +++
> .../prog/en/modules/circ/view_holdsqueue.tt        | 31 +++++++++++++++-------
> 2 files changed, 26 insertions(+), 9 deletions(-)
>
>diff --git a/koha-tmpl/intranet-tmpl/prog/en/css/staff-global.css b/koha-tmpl/intranet-tmpl/prog/en/css/staff-global.css
>index b92f490..588333d 100644
>--- a/koha-tmpl/intranet-tmpl/prog/en/css/staff-global.css
>+++ b/koha-tmpl/intranet-tmpl/prog/en/css/staff-global.css
>@@ -2792,3 +2792,7 @@ div.lastchecked {
> .branchselector {
>     display: table;
> }
>+
>+.hq-author {
>+    font-weight: bold;
>+}
>diff --git a/koha-tmpl/intranet-tmpl/prog/en/modules/circ/view_holdsqueue.tt b/koha-tmpl/intranet-tmpl/prog/en/modules/circ/view_holdsqueue.tt
>index 99ba634..abd2177 100644
>--- a/koha-tmpl/intranet-tmpl/prog/en/modules/circ/view_holdsqueue.tt
>+++ b/koha-tmpl/intranet-tmpl/prog/en/modules/circ/view_holdsqueue.tt
>@@ -67,15 +67,28 @@ $(document).ready(function() {
> 	</thead>
>      <tbody>[% FOREACH itemsloo IN itemsloop %]
>         <tr>
>-            <td class="hq-title"><p><a href="/cgi-bin/koha/catalogue/detail.pl?biblionumber=[% itemsloo.biblionumber %]"><strong>[% itemsloo.title |html %]</strong> [% IF ( itemsloo.subtitle ) %][% itemsloo.subtitle %][% END %]</a></p>
>-                         <p><strong>[% itemsloo.author %]</strong>
>-                       <div class="hq-pubdata">  [% IF ( itemsloo.publishercode ) %][% itemsloo.publishercode %][% END %]
>-                                                                                 [% IF ( itemsloo.publicationyear ) %], [% itemsloo.publicationyear %]
>-                                                                                 [% ELSIF ( itemsloo.copyrightdate ) %], [% itemsloo.copyrightdate %][% END %]
>-                                         [% IF ( itemsloo.pages ) %]: [% itemsloo.pages %] [% END %]
>-                                         [% IF ( itemsloo.item('size') ) %][% itemsloo.item('size') %][% END %] [% IF ( itemsloo.isbn ) %]ISBN: [% itemsloo.isbn %][% END %]</p>
>-			</div>
>-			</td>
>+            <td class="hq-title">
>+                <p><a href="/cgi-bin/koha/catalogue/detail.pl?biblionumber=[% itemsloo.biblionumber %]"><strong>[% itemsloo.title | html %]</strong> [% IF ( itemsloo.subtitle ) %][% itemsloo.subtitle %][% END %]</a></p>
>+                <p>
>+                    <div class="hq-biblionumber content_hidden">[% itemsloo.biblionumber %]</div>
>+                    <div class="hq-author">[% itemsloo.author %]</div>
>+                    <div class="hq-pubdata">
>+                        [% IF ( itemsloo.publishercode ) %][% itemsloo.publishercode %][% END %]
>+
>+                        [% IF ( itemsloo.publicationyear ) %]
>+                            , [% itemsloo.publicationyear %]
>+                        [% ELSIF ( itemsloo.copyrightdate ) %]
>+                            , [% itemsloo.copyrightdate %]
>+                        [% END %]
>+
>+                        [% IF ( itemsloo.pages ) %]: [% itemsloo.pages %] [% END %]
>+
>+                        [% IF ( itemsloo.item('size') ) %][% itemsloo.item('size') %][% END %]
>+
>+                        [% IF ( itemsloo.isbn ) %]ISBN: [% itemsloo.isbn %][% END %]</p>
>+                    </div>
>+                </p>
>+            </td>
>             <td class="hq-collection">[% AuthorisedValues.GetByCode( 'CCODE', itemsloo.ccode ) %]</td>
>             <td class="hq-itemtype">[% ItemTypes.GetDescription( itemsloo.itype ) %]</td>
>             <td class="hq-callnumber">[% IF ( itemsloo.location ) %]<em>[% AuthorisedValues.GetByCode( 'LOC', itemsloo.location ) %]</em> [% END %][% itemsloo.itemcallnumber %]</td>
>-- 
>1.9.1

Actions: View | Diff | Splinter Review

Attachments on bug 13623: 35540 | 35541 | 37845 | 37849 | 38143 | 38144