Bugzilla – Attachment 38152 Details for
Bug 10388
acq edited items showing 'null's
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
[PASSED QA] Bug 10388: Does not display 'null' after editing an item on receiving
PASSED-QA-Bug-10388-Does-not-display-null-after-ed.patch (text/plain), 1.84 KB, created by
Katrin Fischer
on 2015-04-20 05:51:19 UTC
(
hide
)
Description:
[PASSED QA] Bug 10388: Does not display 'null' after editing an item on receiving
Filename:
MIME Type:
Creator:
Katrin Fischer
Created:
2015-04-20 05:51:19 UTC
Size:
1.84 KB
patch
obsolete
>From c9265979bc60edf560b397da0e559b9ccc2c2ff4 Mon Sep 17 00:00:00 2001 >From: Jonathan Druart <jonathan.druart@biblibre.com> >Date: Tue, 7 Apr 2015 17:03:46 +0200 >Subject: [PATCH] [PASSED QA] Bug 10388: Does not display 'null' after editing > an item on receiving > >After editing an item on receiving, 'null' is displayed if no value is >defined for a field. It should be blank. > >Test plan: >0/ Set AcqCreateItem to 'ordering' >1/ Go on the receipt page page >2/ Edit an item >3/ Does not fill all values >4/ Confirm that undefined values are replaced with an empty string > >NOTE: I think you meant receive. Editing requires at least clicking > the dropdown value, even if you don't change it before > clicking save. null's appeared. Post patch application was > able to get nulls to disappear. :) > >Signed-off-by: Mark Tompsett <mtompset@hotmail.com> > >Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> >--- > koha-tmpl/intranet-tmpl/prog/en/modules/acqui/orderreceive.tt | 4 +++- > 1 file changed, 3 insertions(+), 1 deletion(-) > >diff --git a/koha-tmpl/intranet-tmpl/prog/en/modules/acqui/orderreceive.tt b/koha-tmpl/intranet-tmpl/prog/en/modules/acqui/orderreceive.tt >index 014f39b..08565a6 100644 >--- a/koha-tmpl/intranet-tmpl/prog/en/modules/acqui/orderreceive.tt >+++ b/koha-tmpl/intranet-tmpl/prog/en/modules/acqui/orderreceive.tt >@@ -69,7 +69,9 @@ > var tds = $("#item_"+itemnumber+" td"); > for(var i=2; i<tds.length; i++) { > var column = items_columns[i]; >- $(tds[i]).text(item[column]); >+ var text = item[column]; >+ if ( text == null ) text = ''; >+ $(tds[i]).text(text); > } > } > ); >-- >1.9.1
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 10388
:
18567
|
37550
|
37672
| 38152