Attachment 38212 Details for Bug 14008 – [PASSED QA] Bug 14008 - Proposed follow-up: Dialog should appear whenever filters are active

[patch] [PASSED QA] Bug 14008 - Proposed follow-up: Dialog should appear whenever filters are active

PASSED-QA-Bug-14008---Proposed-follow-up-Dialog-sh.patch (text/plain), 1.50 KB, created by Katrin Fischer on 2015-04-20 20:00:21 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: Katrin Fischer

Created: 2015-04-20 20:00:21 UTC

Size: 1.50 KB

patch

obsolete

>From 359a78bdd39da2d1914ec67a902fed5a9b7f1856 Mon Sep 17 00:00:00 2001
>From: =?UTF-8?q?Marc=20V=C3=A9ron?= <veron@veron.ch>
>Date: Sun, 19 Apr 2015 07:37:37 +0200
>Subject: [PATCH] [PASSED QA] Bug 14008 - Proposed follow-up: Dialog should
> appear whenever filters are active
>
>The first patch displays the value(s) of an active filter if you come back to the page or reload the page via a menu action.
>To make the situation more clear the dialog "No saved reports match your criteria." shoudl always appear when a filter is active.
>
>Signed-off-by: Mark Tompsett <mtompset@hotmail.com>
>
>Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de>
>---
> koha-tmpl/intranet-tmpl/prog/en/modules/reports/guided_reports_start.tt | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
>diff --git a/koha-tmpl/intranet-tmpl/prog/en/modules/reports/guided_reports_start.tt b/koha-tmpl/intranet-tmpl/prog/en/modules/reports/guided_reports_start.tt
>index 98cc1ff..34bf1ed 100644
>--- a/koha-tmpl/intranet-tmpl/prog/en/modules/reports/guided_reports_start.tt
>+++ b/koha-tmpl/intranet-tmpl/prog/en/modules/reports/guided_reports_start.tt
>@@ -374,7 +374,7 @@ canned reports and writing custom SQL reports.</p>
>     </div>
> </div>
> [% ELSE %]<div class="dialog message">
>-    [% IF (filter_set) %]
>+    [% IF (filter_set || filters.date || filters.author || filters.keyword) %]
>     <h4>No saved reports match your criteria. </h4>
>     [% IF ( CAN_user_reports_create_reports ) %]
>     <form action="/cgi-bin/koha/reports/guided_reports.pl" method="get">
>-- 
>1.9.1

Actions: View | Diff | Splinter Review

Attachments on bug 14008: 38062 | 38125 | 38136 | 38137 | 38211 | 38212