Attachment 38320 Details for Bug 11006 – Bug 11006: Drop column aqorders.totalamount

[patch] Bug 11006: Drop column aqorders.totalamount

Bug-11006-Drop-column-aqorderstotalamount.patch (text/plain), 2.49 KB, created by Jonathan Druart on 2015-04-22 11:06:13 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: Jonathan Druart

Created: 2015-04-22 11:06:13 UTC

Size: 2.49 KB

patch

obsolete

>From f95466eebae404fb4fb6f6f1c7463443d54c233b Mon Sep 17 00:00:00 2001
>From: Jonathan Druart <jonathan.druart@biblibre.com>
>Date: Wed, 22 Apr 2015 13:03:53 +0200
>Subject: [PATCH] Bug 11006: Drop column aqorders.totalamount
>
>This column was not used in the Koha codebase, it can be removed.
>
>Test plan:
>Execute the updatedatabase.pl script and confirm that the column has
>been dropped.
>
>QA step:
>1/ git grep totalamount
>2/ prove t/db_dependent/Acquisition.t
>---
> .../data/mysql/atomicupdate/bug_11006-DROP_COLUMN_totalamount.sql      | 1 +
> installer/data/mysql/kohastructure.sql                                 | 1 -
> t/db_dependent/Acquisition.t                                           | 3 ---
> 3 files changed, 1 insertion(+), 4 deletions(-)
> create mode 100644 installer/data/mysql/atomicupdate/bug_11006-DROP_COLUMN_totalamount.sql
>
>diff --git a/installer/data/mysql/atomicupdate/bug_11006-DROP_COLUMN_totalamount.sql b/installer/data/mysql/atomicupdate/bug_11006-DROP_COLUMN_totalamount.sql
>new file mode 100644
>index 0000000..3cd0843
>--- /dev/null
>+++ b/installer/data/mysql/atomicupdate/bug_11006-DROP_COLUMN_totalamount.sql
>@@ -0,0 +1 @@
>+ALTER TABLE aqorders DROP COLUMN totalamount;
>diff --git a/installer/data/mysql/kohastructure.sql b/installer/data/mysql/kohastructure.sql
>index a74d81a..63a0b93 100644
>--- a/installer/data/mysql/kohastructure.sql
>+++ b/installer/data/mysql/kohastructure.sql
>@@ -3030,7 +3030,6 @@ CREATE TABLE `aqorders` ( -- information related to the basket line items
>   `quantity` smallint(6) default NULL, -- the quantity ordered
>   `currency` varchar(3) default NULL, -- the currency used for the purchase
>   `listprice` decimal(28,6) default NULL, -- the vendor price for this line item
>-  `totalamount` decimal(28,6) default NULL, -- not used? always NULL
>   `datereceived` date default NULL, -- the date this order was received
>   invoiceid int(11) default NULL, -- id of invoice
>   `freight` decimal(28,6) default NULL, -- shipping costs (not used)
>diff --git a/t/db_dependent/Acquisition.t b/t/db_dependent/Acquisition.t
>index f41a345..561b5af 100755
>--- a/t/db_dependent/Acquisition.t
>+++ b/t/db_dependent/Acquisition.t
>@@ -331,7 +331,6 @@ my @expectedfields = qw(
>   quantity
>   currency
>   listprice
>-  totalamount
>   datereceived
>   invoiceid
>   freight
>@@ -482,7 +481,6 @@ my @base_expectedfields = qw(
>   budget_expend
>   rrp
>   cn_sort
>-  totalamount
>   lccn
>   sort1
>   volume
>@@ -603,7 +601,6 @@ ok(
>   sort2_authcat
>   rrp
>   unitprice
>-  totalamount
>   sort1
>   ordernumber
>   datecreated
>-- 
>2.1.0

Actions: View | Diff | Splinter Review

Attachments on bug 11006: 38320 | 38393 | 38402 | 39186