Bugzilla – Attachment 38335 Details for
Bug 1917
Add RSS Feeds for Lists
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
Bug 1917 [QA Followup] - Don't limit the list results for RSS feeds
Bug-1917-QA-Followup---Dont-limit-the-list-results.patch (text/plain), 2.78 KB, created by
Martin Renvoize (ashimema)
on 2015-04-22 12:42:31 UTC
(
hide
)
Description:
Bug 1917 [QA Followup] - Don't limit the list results for RSS feeds
Filename:
MIME Type:
Creator:
Martin Renvoize (ashimema)
Created:
2015-04-22 12:42:31 UTC
Size:
2.78 KB
patch
obsolete
>From 32415eac425f3e9ea9a269c463c4152f539b533d Mon Sep 17 00:00:00 2001 >From: Kyle M Hall <kyle@bywatersolutions.com> >Date: Wed, 22 Apr 2015 07:36:51 -0400 >Subject: [PATCH] Bug 1917 [QA Followup] - Don't limit the list results for > RSS feeds > >Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> >--- > C4/VirtualShelves/Page.pm | 16 ++++++++++------ > 1 file changed, 10 insertions(+), 6 deletions(-) > >diff --git a/C4/VirtualShelves/Page.pm b/C4/VirtualShelves/Page.pm >index a92b989..b339026 100644 >--- a/C4/VirtualShelves/Page.pm >+++ b/C4/VirtualShelves/Page.pm >@@ -78,10 +78,12 @@ sub shelfpage { > > $shelflimit = ( $type eq 'opac' ? C4::Context->preference('OPACnumSearchResults') : C4::Context->preference('numSearchResults') ); > $shelflimit = $shelflimit || ShelvesMax('MGRPAGE'); >+ $shelflimit = undef if $query->param('rss'); > $shelfoffset = ( $itemoff - 1 ) * $shelflimit; # Sets the offset to begin retrieving items at > $shelveslimit = $shelflimit; # Limits number of shelves returned for a given query (row_count) > $shelvesoffset = ( $shelfoff - 1 ) * $shelflimit; # Sets the offset to begin retrieving shelves at (offset) >- # getting the Shelves list >+ >+ # getting the Shelves list > my $category = ( ( $displaymode eq 'privateshelves' ) ? 1 : 2 ); > my $shelflist = GetShelves( $category, $shelveslimit, $shelvesoffset, $loggedinuser ); > my $totshelves = C4::VirtualShelves::GetShelfCount( $loggedinuser, $category ); >@@ -459,11 +461,13 @@ sub shelfpage { > $qhash{$_} = $query->param($_) if $query->param($_); > } > ( scalar keys %qhash ) and $url .= '?' . join '&', map { "$_=$qhash{$_}" } keys %qhash; >- if ( $shelfnumber && $totitems ) { >- $template->param( pagination_bar => pagination_bar( $url, ( int( $totitems / $shelflimit ) ) + ( ( $totitems % $shelflimit ) > 0 ? 1 : 0 ), $itemoff, "itemoff" ) ); >- } elsif ( $totshelves ) { >- $template->param( >- pagination_bar => pagination_bar( $url, ( int( $totshelves / $shelveslimit ) ) + ( ( $totshelves % $shelveslimit ) > 0 ? 1 : 0 ), $shelfoff, "shelfoff" ) ); >+ if ( $shelflimit ) { >+ if ( $shelfnumber && $totitems ) { >+ $template->param( pagination_bar => pagination_bar( $url, ( int( $totitems / $shelflimit ) ) + ( ( $totitems % $shelflimit ) > 0 ? 1 : 0 ), $itemoff, "itemoff" ) ); >+ } elsif ( $totshelves ) { >+ $template->param( >+ pagination_bar => pagination_bar( $url, ( int( $totshelves / $shelveslimit ) ) + ( ( $totshelves % $shelveslimit ) > 0 ? 1 : 0 ), $shelfoff, "shelfoff" ) ); >+ } > } > $template->param( > shelveslooppriv => \@shelveslooppriv, >-- >1.7.10.4
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 1917
:
38104
|
38105
|
38106
|
38117
|
38199
|
38200
|
38201
|
38218
|
38219
|
38263
|
38325
|
38332
|
38333
|
38334
| 38335