Attachment 38340 Details for Bug 14044 – Bug 14044 - Backslashes ( and possibly other characters ) break patron search

[patch] Bug 14044 - Backslashes ( and possibly other characters ) break patron search

Bug-14044---Backslashes--and-possibly-other-charac.patch (text/plain), 3.92 KB, created by Kyle M Hall (khall) on 2015-04-22 13:42:17 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: Kyle M Hall (khall)

Created: 2015-04-22 13:42:17 UTC

Size: 3.92 KB

patch

obsolete

>From 205159083792c2907feffd79c3a3ffe43569c97c Mon Sep 17 00:00:00 2001
>From: Kyle M Hall <kyle@bywatersolutions.com>
>Date: Wed, 22 Apr 2015 09:39:55 -0400
>Subject: [PATCH] Bug 14044 - Backslashes ( and possibly other characters ) break patron search
>
>If a patron has a backslash character ( \ ) in a field displayed in the
>patron search, and that patron is part of a set of search results, those
>search results will never display. Instead, it will just sit at the
>"Processing..." message forever.
>
>Test Plan:
>1) Edit a patron, add a backslash to the address for the patron
>2) Do a patron search where this patron would be one of many results
>3) Note the results never display
>4) Apply this patch
>5) Repeat step 2
>6) Note the results now display
>---
> .../en/modules/members/tables/members_results.tt | 5 +++--
> 1 files changed, 3 insertions(+), 2 deletions(-)
>
>diff --git a/koha-tmpl/intranet-tmpl/prog/en/modules/members/tables/members_results.tt b/koha-tmpl/intranet-tmpl/prog/en/modules/members/tables/members_results.tt
>index 00b02af..e56d41e 100644
>--- a/koha-tmpl/intranet-tmpl/prog/en/modules/members/tables/members_results.tt
>+++ b/koha-tmpl/intranet-tmpl/prog/en/modules/members/tables/members_results.tt
>@@ -1,3 +1,4 @@
>+[% USE To %]
> [% USE AuthorisedValues %]
> {
> "sEcho": [% sEcho %],
>@@ -11,9 +12,9 @@
> "<input type='checkbox' class='selection' name='borrowernumber' value='[% data.borrowernumber %]' />",
> [% END %]
> "dt_cardnumber":
>- "[% data.cardnumber %]",
>+ "[% data.cardnumber | html %]",
> "dt_name":
>- "<a href='/cgi-bin/koha/members/moremember.pl?borrowernumber=[% data.borrowernumber %]'>[% INCLUDE 'patron-title.inc' borrowernumber = data.borrowernumber category_type = data.category_type firstname = data.firstname surname = data.surname othernames = data.othernames invert_name = 1%]</a> [% IF ( data.streetnumber ) %][% data.streetnumber %] [% END %][% IF ( data.streettype ) %][% AuthorisedValues.GetByCode( 'ROADTYPE', data.streettype ) %] [% END %][% data.address %][% IF ( data.address2 ) %] [% data.address2 %][% END %][% IF ( data.city || data.state || data.zipcode || data.country) %] [% END %][% IF ( data.city ) %][% data.city %][% IF ( data.state ) %],[% END %][% END %][% IF ( data.state ) %] [% data.state %][% END %] [% IF ( data.zipcode ) %] [% data.zipcode %][% END %][% IF ( data.country ) %], [% data.country %][% END %][% IF data.email %] Email&#58; <a href='mailto&#58;[% data.email %]'>[% data.email %]</a>[% END %]",
>+ "<a href='/cgi-bin/koha/members/moremember.pl?borrowernumber=[% data.borrowernumber %]'>[% INCLUDE 'patron-title.inc' borrowernumber = data.borrowernumber category_type = data.category_type firstname = data.firstname surname = data.surname othernames = data.othernames invert_name = 1 %]</a> [% IF ( data.streetnumber ) %][% To.json( data.streetnumber ) | html %] [% END %][% IF ( data.streettype ) %][% To.json( AuthorisedValues.GetByCode( 'ROADTYPE', data.streettype ) ) | html %] [% END %][% To.json( data.address ) | html %][% IF ( data.address2 ) %] [% To.json( data.address2 ) | html %][% END %][% IF ( data.city || data.state || data.zipcode || data.country) %] [% END %][% IF ( data.city ) %][% To.json( data.city ) | html %][% IF ( data.state ) %],[% END %][% END %][% IF ( data.state ) %] [% To.json( data.state ) | html %][% END %] [% IF ( data.zipcode ) %] [% To.json( data.zipcode ) | html %][% END %][% IF ( data.country ) %], [% To.json( data.country ) | html %][% END %][% IF data.email %] Email&#58; <a href='mailto&#58;[% To.json( data.email ) | html %]'>[% data.email %]</a>[% END %]",
> "dt_category":
> "[% data.category_description |html %] ([% data.category_type |html %])",
> "dt_branch":
>-- 
>1.7.2.5

Actions: View | Diff | Splinter Review

Attachments on bug 14044: 38340 | 38343 | 38542 | 38641 | 38671 | 38718 | 38790 | 38791