Bugzilla – Attachment 38384 Details for
Bug 10886
Hide patron information in item history if intranetreadinghistory is set to not allow
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
[Signed-off] Bug 10866: Hide patron's history if intranetreadinghistory is set to not allow
Signed-off-Bug-10866-Hide-patrons-history-if-intra.patch (text/plain), 4.73 KB, created by
Marc Véron
on 2015-04-23 07:09:23 UTC
(
hide
)
Description:
[Signed-off] Bug 10866: Hide patron's history if intranetreadinghistory is set to not allow
Filename:
MIME Type:
Creator:
Marc Véron
Created:
2015-04-23 07:09:23 UTC
Size:
4.73 KB
patch
obsolete
>From 765fe83e673b913f07f9bed1f821e7c9917c9854 Mon Sep 17 00:00:00 2001 >From: Jonathan Druart <jonathan.druart@biblibre.com> >Date: Wed, 22 Apr 2015 12:14:24 +0200 >Subject: [PATCH] [Signed-off] Bug 10866: Hide patron's history if > intranetreadinghistory is set to not allow >MIME-Version: 1.0 >Content-Type: text/plain; charset=UTF-8 >Content-Transfer-Encoding: 8bit > >If set to "not allow", the intranetreadinghistory pref prevent staff >members to access patron's checkout history. >But: >1/ The page is still accessible if you know the url >2/ The history can be consulted on the item history page > >Test plan: >0/ Don't apply this patch >1/ Set the intranetreadinghistory to allow >2/ Go on a patron's checkout history page >3/ Open a new tab and go on a item's checkout history page >4/ Set the intranetreadinghistory to not allow >5/ Refresh both pages => no change >6/ Apply this patch >7/ Refresh both page. >On the first page, you should see a warning >On the other one, you should see that the patron column is not displayed >anymore. > >Followed test plan, results were as expected. >Signed-off-by: Marc Véron <veron@veron.ch> > >http://bugs.koha-community.org/show_bug.cgi?id=10886 >--- > .../prog/en/modules/catalogue/issuehistory.tt | 26 +++++++++++--------- > .../prog/en/modules/members/readingrec.tt | 4 ++- > 2 files changed, 18 insertions(+), 12 deletions(-) > >diff --git a/koha-tmpl/intranet-tmpl/prog/en/modules/catalogue/issuehistory.tt b/koha-tmpl/intranet-tmpl/prog/en/modules/catalogue/issuehistory.tt >index 7b6483c..89531f4 100644 >--- a/koha-tmpl/intranet-tmpl/prog/en/modules/catalogue/issuehistory.tt >+++ b/koha-tmpl/intranet-tmpl/prog/en/modules/catalogue/issuehistory.tt >@@ -1,3 +1,4 @@ >+[% USE Koha %] > [% USE KohaDates %] > [% INCLUDE 'doc-head-open.inc' %] > <title>Koha › Catalog › Checkout history for [% title |html %]</title> >@@ -7,13 +8,12 @@ > <script type="text/javascript" id="js"> > $(document).ready(function() { > $("#table_issues").dataTable($.extend(true, {}, dataTablesDefaults, { >- "aoColumns": [ >- null,null,null,null,{ "sType": "title-string" },{ "sType": "title-string" },{ "sType": "title-string" } >- ], >- "aaSorting": [[ 4, "desc" ]], >- "sPaginationType": "full_numbers" >- }) >- ); >+ "aoColumnDefs": [ >+ { "sType": "title-string", "aTargets" : [ "title-string" ] } >+ ], >+ "aaSorting": [[ 4, "desc" ]], >+ "sPaginationType": "full_numbers" >+ })); > }); </script> > > </head> >@@ -38,18 +38,22 @@ $(document).ready(function() { > <h4>Checked out [% total %] times</h4> > <table id="table_issues"> > <thead><tr> >+ [% IF Koha.Preference('intranetreadinghistory') %] > <th>Patron</th> >+ [% END %] > <th>Barcode</th> > <th>Checked out from</th> > <th>Renewed</th> >- <th>Checkout on</th> >- <th>Due date</th> >- <th>Checkin on</th> >+ <th class='title-string'>Checkout on</th> >+ <th class='title-string'>Due date</th> >+ <th class='title-string'>Checkin on</th> > </tr></thead> > <tbody> > [% FOREACH issue IN issues %] >- [% UNLESS ( loop.odd ) %]<tr class="highlight">[% ELSE %]<tr>[% END %] >+ <tr> >+ [% IF Koha.Preference('intranetreadinghistory') %] > <td><a href="/cgi-bin/koha/members/moremember.pl?borrowernumber=[% issue.borrowernumber %]">[% IF HidePatronName %][% issue.cardnumber %][% ELSE %][% issue.surname %][% IF ( issue.firstname ) %], [% issue.firstname %][% END %][% END %]</a></td> >+ [% END %] > <td>[% IF ( issue.barcode ) %] > <a href="/cgi-bin/koha/catalogue/moredetail.pl?biblionumber=[% issue.biblionumber %]&itemnumber=[% issue.itemnumber %]">[% issue.barcode %]</a> > [% ELSE %] >diff --git a/koha-tmpl/intranet-tmpl/prog/en/modules/members/readingrec.tt b/koha-tmpl/intranet-tmpl/prog/en/modules/members/readingrec.tt >index 0d4afa9..9afebf3 100644 >--- a/koha-tmpl/intranet-tmpl/prog/en/modules/members/readingrec.tt >+++ b/koha-tmpl/intranet-tmpl/prog/en/modules/members/readingrec.tt >@@ -48,7 +48,9 @@ > [% INCLUDE 'members-toolbar.inc' %] > <h1>Circulation history</h1> > >-[% IF is_anonymous %] >+[% UNLESS Koha.Preference('intranetreadinghistory') %] >+ <div class="dialog alert">Staff members are not allowed to access patron's checkout history</div> >+[% ELSIF is_anonymous %] > <div class="dialog alert">This is the anonymous patron, so no circulation history is displayed. To get a list of anonymized loans, please run a report.</div> > [% ELSIF ( !loop_reading ) %] > <div class="dialog message">This patron has no circulation history.</div> >-- >1.7.10.4
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 10886
:
38318
|
38384
|
38396