Bugzilla – Attachment 38407 Details for
Bug 13889
Add information about cron jobs to system log
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
[PASSED QA] Bug 13889: Added Test Coverage
PASSED-QA-Bug-13889-Added-Test-Coverage.patch (text/plain), 1.93 KB, created by
Kyle M Hall (khall)
on 2015-04-23 11:53:19 UTC
(
hide
)
Description:
[PASSED QA] Bug 13889: Added Test Coverage
Filename:
MIME Type:
Creator:
Kyle M Hall (khall)
Created:
2015-04-23 11:53:19 UTC
Size:
1.93 KB
patch
obsolete
>From 7ccef99011a73945793e95770b99ac7bd3460b61 Mon Sep 17 00:00:00 2001 >From: Mark Tompsett <mtompset@hotmail.com> >Date: Mon, 20 Apr 2015 04:32:06 -0400 >Subject: [PATCH] [PASSED QA] Bug 13889: Added Test Coverage >MIME-Version: 1.0 >Content-Type: text/plain; charset=UTF-8 >Content-Transfer-Encoding: 8bit > >Previous commit was lacking test coverage of new function. > >TEST PLAN >--------- >1) Apply all the patches >2) prove -v t/db_dependent/Log.t > -- should be success. >3) koha qa test tools > >Signed-off-by: Marc Véron <veron@veron.ch> > >Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> >--- > t/db_dependent/Log.t | 27 ++++++++++++++++++++++++++- > 1 files changed, 26 insertions(+), 1 deletions(-) > >diff --git a/t/db_dependent/Log.t b/t/db_dependent/Log.t >index 8a25c18..cbd8937 100644 >--- a/t/db_dependent/Log.t >+++ b/t/db_dependent/Log.t >@@ -6,10 +6,15 @@ > > use strict; > use warnings; >-use Test::More tests => 5; >+use Test::More tests => 7; > > # We need C4::Dates to handle the dates > use C4::Dates; >+use C4::Context; >+use t::lib::Mocks qw/mock_preference/; # to mock CronjobLog >+use Data::Dumper; >+ >+$| = 1; > > BEGIN { > use_ok('C4::Log'); >@@ -53,3 +58,23 @@ eval { > $success = 0; > }; > ok($success, "GetLogs seemed to find ".$success." like our test record in a tighter search"); >+ >+# Make sure we can rollback. >+my $dbh = C4::Context->dbh; >+$dbh->{AutoCommit} = 0; >+$dbh->{RaiseError} = 1; >+ >+# We want numbers to be the same between runs. >+$dbh->do("DELETE FROM action_logs;"); >+ >+t::lib::Mocks::mock_preference('CronjobLog',0); >+cronlogaction(); >+my $cronJobCount = $dbh->selectrow_array("SELECT COUNT(*) FROM action_logs WHERE module='CRONJOBS';",{}); >+is($cronJobCount,0,"Cronjob not logged as expected."); >+ >+t::lib::Mocks::mock_preference('CronjobLog',1); >+cronlogaction(); >+$cronJobCount = $dbh->selectrow_array("SELECT COUNT(*) FROM action_logs WHERE module='CRONJOBS';",{}); >+is($cronJobCount,1,"Cronjob logged as expected."); >+ >+$dbh->rollback(); >-- >1.7.2.5
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 13889
:
37082
|
37325
|
37679
|
37707
|
37711
|
38116
|
38183
|
38227
|
38228
|
38229
|
38230
|
38236
|
38239
|
38283
|
38406
| 38407 |
38408
|
38409