Attachment 38665 Details for Bug 14038 – Bug 14038: Make nl-search.pl not using C4::Members::Search

[patch] Bug 14038: Make nl-search.pl not using C4::Members::Search

Bug-14038-Make-nl-searchpl-not-using-C4MembersSear.patch (text/plain), 1.76 KB, created by Magnus Enger on 2015-04-29 12:56:18 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: Magnus Enger

Created: 2015-04-29 12:56:18 UTC

Size: 1.76 KB

patch

obsolete

>From e59237fad6f2ffe74ede5fd454f1c8c9a30f929d Mon Sep 17 00:00:00 2001
>From: Jonathan Druart <jonathan.druart@biblibre.com>
>Date: Wed, 22 Apr 2015 10:19:33 +0200
>Subject: [PATCH] Bug 14038: Make nl-search.pl not using C4::Members::Search
>
>To get rid of SQLHelper, we should not use this C4::Members::Search anymore.
>
>Test plan for Magnus :)
>0/ Enable the pref you need to use the Norwegian national library card ft
>1/ Go on the members/nl-search.pl page and search for patrons.
>2/ Make sure you search by card number and by "social security number"
>
>Signed-off-by: Magnus Enger <magnus@enger.priv.no>
>Searching works the same with and without the patch. Thanks Jonathan!
>---
> members/nl-search.pl | 8 +++++++-
> 1 file changed, 7 insertions(+), 1 deletion(-)
>
>diff --git a/members/nl-search.pl b/members/nl-search.pl
>index 384b1fe..08f3a04 100755
>--- a/members/nl-search.pl
>+++ b/members/nl-search.pl
>@@ -42,6 +42,7 @@ use C4::Context;
> use C4::Output;
> use C4::Members;
> use C4::Members::Attributes qw( SetBorrowerAttributes );
>+use C4::Utils::DataTables::Members;
> use Koha::NorwegianPatronDB qw( NLCheckSysprefs NLSearch NLDecodePin NLGetFirstname NLGetSurname NLSync );
> use Koha::Database;
> use Koha::DateUtils;
>@@ -77,7 +78,12 @@ if ( $op && $op eq 'search' ) {
>     my $identifier = $cgi->param('q');
>     if ( $identifier ) {
>         # Local search
>-        my $local_results = Search( $identifier );
>+        my $local_results = C4::Utils::DataTables::Members::search(
>+            {
>+                searchmember => $identifier,
>+                dt_params => { iDisplayLength => -1 },
>+            }
>+        )->{patrons};
>         $template->param( 'local_result' => $local_results );
>         # Search NL, unless we got at least one hit and further searching is
>         # disabled
>-- 
>1.9.1

Actions: View | Diff | Splinter Review

Attachments on bug 14038: 38306 | 38665 | 38694