Attachment 38685 Details for Bug 14077 – [PASSED QA] Bug 14077 - Remove unused AUTH_UPDATE_FAILED from moremember.tt

[patch] [PASSED QA] Bug 14077 - Remove unused AUTH_UPDATE_FAILED from moremember.tt

PASSED-QA-Bug-14077---Remove-unused-AUTHUPDATEFAIL.patch (text/plain), 1.87 KB, created by Katrin Fischer on 2015-04-29 20:11:07 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: Katrin Fischer

Created: 2015-04-29 20:11:07 UTC

Size: 1.87 KB

patch

obsolete

>From 095818a7411eda353b339e3abbab5100d9523eb8 Mon Sep 17 00:00:00 2001
>From: =?UTF-8?q?Marc=20V=C3=A9ron?= <veron@veron.ch>
>Date: Wed, 29 Apr 2015 11:34:40 +0200
>Subject: [PATCH] [PASSED QA] Bug 14077 - Remove unused AUTH_UPDATE_FAILED from
> moremember.tt
>
>'AUTH_UPDATE_FAILED' in moremember.tt is never set and should be removed (see comment #6 on Bug 13910).
>
>To verify: git grep 'AUTH_UPDATE_FAILED'
>Result: Only one occurence (in moremember.tt)
>
>Test plan:
>- Apply patch (on top of Bug 13910)
>- Verify that the part with AUTH_UPDATE_FAILED is removed from moremember.tt
>- Go to a patron's detail page and verify that nothing is broken (Home > Patrons > Patrons details for...)
>
>Signed-off-by: Jonathan Druart <jonathan.druart@biblibre.com>
>This has been introduced by
>  commit 1a91801b06607ee9e5f8c21d531a7b7a3ca3b683
>  Date:   Sat Dec 1 20:56:27 2007 -0600
>      Add Staff member type. Add permissions checks for bug# 1269
>      and related permissions on memberentry and mods.
>But was already not used...
>
>Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de>
>---
> koha-tmpl/intranet-tmpl/prog/en/modules/members/moremember.tt | 5 -----
> 1 file changed, 5 deletions(-)
>
>diff --git a/koha-tmpl/intranet-tmpl/prog/en/modules/members/moremember.tt b/koha-tmpl/intranet-tmpl/prog/en/modules/members/moremember.tt
>index 5f3e5c4..3210860 100644
>--- a/koha-tmpl/intranet-tmpl/prog/en/modules/members/moremember.tt
>+++ b/koha-tmpl/intranet-tmpl/prog/en/modules/members/moremember.tt
>@@ -143,11 +143,6 @@ function validate1(date) {
> 
> [% IF ( error ) %]
> <div class="dialog alert">
>-    [% IF ( AUTH_UPDATE_FAILED ) %]
>-        <h3>Userid / Password update failed</h3>
>-        <strong>Insufficient privileges.</strong>
>-        <p>Other fields updated.</p>
>-    [% END %]
>     [% IF ( error == 'CANT_DELETE_STAFF' ) %]
>         <h3>Unable to delete staff user</h3>
>         <p>Insufficient privileges.</p>
>-- 
>1.9.1

Actions: View | Diff | Splinter Review

Attachments on bug 14077: 38653 | 38654 | 38685