Attachment 38698 Details for Bug 12633 – [PASSED QA] Bug 12633: Fix specific default values

[patch] [PASSED QA] Bug 12633: Fix specific default values

PASSED-QA-Bug-12633-Fix-specific-default-values.patch (text/plain), 1.19 KB, created by Katrin Fischer on 2015-04-29 21:02:06 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: Katrin Fischer

Created: 2015-04-29 21:02:06 UTC

Size: 1.19 KB

patch

obsolete

>From ef25a5a9e03972c08d89fb41a9c6ff3900e65483 Mon Sep 17 00:00:00 2001
>From: Jonathan Druart <jonathan.druart@biblibre.com>
>Date: Tue, 21 Apr 2015 16:50:12 +0200
>Subject: [PATCH] [PASSED QA] Bug 12633: Fix specific default values
>
>The dates should be set to undef if defined but empty, otherwise with an
>empty string, '0000-00-00' will be inserted into the DB.
>
>Signed-off-by: Mirko Tietgen <mirko@abunchofthings.net>
>
>Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de>
>---
> C4/Members.pm | 3 +++
> 1 file changed, 3 insertions(+)
>
>diff --git a/C4/Members.pm b/C4/Members.pm
>index 81e83ac..c5e5453 100644
>--- a/C4/Members.pm
>+++ b/C4/Members.pm
>@@ -670,6 +670,9 @@ sub ModMember {
>     my $new_borrower = { map { join(' ', @columns) =~ /$_/ ? ( $_ => $data{$_} ) : () } keys(%data) };
>     delete $new_borrower->{flags};
> 
>+    $new_borrower->{dateofbirth}  ||= undef if exists $new_borrower->{dateofbirth};
>+    $new_borrower->{dateenrolled} ||= undef if exists $new_borrower->{dateenrolled};
>+    $new_borrower->{dateexpiry}   ||= undef if exists $new_borrower->{dateexpiry};
>     my $rs = $schema->resultset('Borrower')->search({
>         borrowernumber => $new_borrower->{borrowernumber},
>      });
>-- 
>1.9.1

Actions: View | Diff | Splinter Review

Attachments on bug 12633: 30115 | 30119 | 30547 | 30937 | 37751 | 38272 | 38284 | 38285 | 38697 | 38698 | 57270