Attachment 38710 Details for Bug 5685 – Bug 5685 [OPAC follow-up] Validation of email address field

[patch] Bug 5685 [OPAC follow-up] Validation of email address field

Bug-5685-OPAC-follow-up-Validation-of-email-addres.patch (text/plain), 3.99 KB, created by Mark Tompsett on 2015-04-30 00:56:58 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: Mark Tompsett

Created: 2015-04-30 00:56:58 UTC

Size: 3.99 KB

patch

obsolete

>From 598858c00c20579ce60239440e620bc3a0a5b822 Mon Sep 17 00:00:00 2001
>From: Owen Leonard <oleonard@myacpl.org>
>Date: Thu, 23 Oct 2014 09:50:38 -0400
>Subject: [PATCH] Bug 5685 [OPAC follow-up] Validation of email address field
>
>This patch makes a few changes to the way errors are handled in the
>OPAC:
>
>- The validation plugin has been moved from the global include file to
>  the template itself. Since we aren't doing form validation on any
>  other page yet it doesn't make sense to include it globally at this
>  time.
>
>- The error message which appears if you have JavaScript disabled and
>  have submitted invalid emails was styled in a non-standard way.
>
>- I have added in-page links to the error message which appears if you
>  have JavaScript disabled so that you can click to jump to the field
>  which contains the error.
>
>- I have modified the error message language slightly to make it (I
>  hope) read better.
>
>Signed-off-by: Nicole Engard <nengard@bywatersolutions.com>
>---
> koha-tmpl/opac-tmpl/bootstrap/en/includes/opac-bottom.inc    |  1 -
> koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-memberentry.tt | 11 ++++++-----
> 2 files changed, 6 insertions(+), 6 deletions(-)
>
>diff --git a/koha-tmpl/opac-tmpl/bootstrap/en/includes/opac-bottom.inc b/koha-tmpl/opac-tmpl/bootstrap/en/includes/opac-bottom.inc
>index a38e85a..59b0464 100644
>--- a/koha-tmpl/opac-tmpl/bootstrap/en/includes/opac-bottom.inc
>+++ b/koha-tmpl/opac-tmpl/bootstrap/en/includes/opac-bottom.inc
>@@ -77,7 +77,6 @@
> 
> <script type="text/javascript" src="[% interface %]/[% theme %]/lib/jquery/jquery.js"></script>
> <script type="text/javascript" src="[% interface %]/[% theme %]/lib/jquery/jquery-ui.js"></script>
>-<script type="text/javascript" src="[% interface %]/[% theme %]/lib/jquery/plugins/jquery.validate.min.js"></script>
> <script type="text/javascript">
> // Resolve name collision between jQuery UI and Twitter Bootstrap
> $.widget.bridge('uitooltip', $.ui.tooltip);
>diff --git a/koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-memberentry.tt b/koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-memberentry.tt
>index adbfd19..810b761 100644
>--- a/koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-memberentry.tt
>+++ b/koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-memberentry.tt
>@@ -51,15 +51,15 @@
>                 [% END %]
> 
>                 [%  IF invalid_form_fields %]
>-                    <div class="alert-error"><strong>The following fields are invalid:</strong>
>+                    <div class="alert alert-error"><strong>The following fields contain invalid information:</strong>
>                         <ul>
>                             [% FOREACH field IN invalid_form_fields %]
>-                                [% IF field == "email" %]<li>Primary contact information: primary email address</li>[% END %]
>-                                [% IF field == "emailpro" %]<li>Primary contact information: secondary email address</li>[% END %]
>-                                [% IF field == "B_email" %]<li>Alternative contact information: email address</li>[% END %]
>+                                [% IF field == "email" %]<li>Contact information: <a href="#borrower_email">primary email address</a></li>[% END %]
>+                                [% IF field == "emailpro" %]<li>Contact information: <a href="#borrower_emailpro">secondary email address</a></li>[% END %]
>+                                [% IF field == "B_email" %]<li>Alternate address information: <a href="#borrower_B_email">email address</a></li>[% END %]
>                             [% END %]
>                         </ul>
>-                        Please correct them.
>+                        Please correct the errors and resubmit.
>                     </div>
>                 [% END %]
> 
>@@ -796,6 +796,7 @@
> 
> [% INCLUDE 'opac-bottom.inc' %]
> [% BLOCK jsinclude %]
>+    <script type="text/javascript" src="[% interface %]/[% theme %]/lib/jquery/plugins/jquery.validate.min.js"></script>
>     <script type="text/javascript">
>         //<![CDATA[
>         $(document).ready(function() {
>-- 
>2.1.4

Actions: View | Diff | Splinter Review

Attachments on bug 5685: 3814 | 3860 | 30829 | 32622 | 32623 | 32624 | 37391 | 37392 | 37393 | 38063 | 38064 | 38065 | 38707 | 38708 | 38709 | 38710 | 38711 | 38715 | 38744 | 38745 | 38746 | 38747