Attachment 38741 Details for Bug 10235 – Bug 10235: Add DataTables filters on local use prefs

[patch] Bug 10235: Add DataTables filters on local use prefs

Bug-10235-Add-DataTables-filters-on-local-use-pref.patch (text/plain), 1.83 KB, created by Mark Tompsett on 2015-05-01 13:32:11 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: Mark Tompsett

Created: 2015-05-01 13:32:11 UTC

Size: 1.83 KB

patch

obsolete

>From 779c54c810b0b826b226d3a5bc11ea11f658477d Mon Sep 17 00:00:00 2001
>From: Jonathan Druart <jonathan.druart@biblibre.com>
>Date: Tue, 14 Apr 2015 16:07:07 +0200
>Subject: [PATCH] Bug 10235: Add DataTables filters on local use prefs
>
>There is no way to search for local use prefs.
>This patch provides an easy way to search for pref present in
>of local use prefs table.
>
>Test plan:
>1/ Go on the system preferences administration page
>2/ Click on the Local Use table
>3/ Confirm you are able to filter the table by pref name or description
>using the DataTables filters on top of it.
>
>Signed-off-by: Mark Tompsett <mtompset@hotmail.com>
>
>NOTE: Local use tab is distinct from other tabs, so implementing
>      'Search system preferences' across all tabs would be very
>      difficult. This patch adds a filter to the Local Use tab,
>      which nicely allows for filtering, as per Owen's suggestion
>      in comment #1.
>---
> koha-tmpl/intranet-tmpl/prog/en/modules/admin/systempreferences.tt | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
>diff --git a/koha-tmpl/intranet-tmpl/prog/en/modules/admin/systempreferences.tt b/koha-tmpl/intranet-tmpl/prog/en/modules/admin/systempreferences.tt
>index 2d27d83..dba6c08 100644
>--- a/koha-tmpl/intranet-tmpl/prog/en/modules/admin/systempreferences.tt
>+++ b/koha-tmpl/intranet-tmpl/prog/en/modules/admin/systempreferences.tt
>@@ -9,9 +9,9 @@
>     //<![CDATA[
>      $(document).ready(function() {
>         [% IF ( loop ) %]$("#sysprefst").dataTable($.extend(true, {}, dataTablesDefaults, {
>-            "sDom": 't',
>+            "sDom": '<"top pager"ilf>t',
>             "aoColumnDefs": [
>-                { "aTargets": [ -1, -2, -3, -4 ], "bSortable": false, "bSearchable": false }
>+                { "aTargets": [ -1, -2, -3, -4 ], "bSortable": false }
>             ],
>             "bPaginate": false
>         }));[% END %]
>-- 
>2.1.4

Actions: View | Diff | Splinter Review

Attachments on bug 10235: 37822 | 38740 | 38741 | 38779