Attachment 38783 Details for Bug 11890 – [PASSED QA] Bug 11890: Prevent default on click event

[patch] [PASSED QA] Bug 11890: Prevent default on click event

PASSED-QA-Bug-11890-Prevent-default-on-click-event.patch (text/plain), 1.32 KB, created by Katrin Fischer on 2015-05-03 16:55:04 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: Katrin Fischer

Created: 2015-05-03 16:55:04 UTC

Size: 1.32 KB

patch

obsolete

>From 7a848ae42abf520a8aad126444935c77472a7ea3 Mon Sep 17 00:00:00 2001
>From: Jonathan Druart <jonathan.druart@biblibre.com>
>Date: Wed, 29 Apr 2015 09:42:40 +0200
>Subject: [PATCH] [PASSED QA] Bug 11890: Prevent default on click event
>
>It seems that the previous patch does not stop the propagation of the
>event if the link is clicked with the left button (which=1).
>
>Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de>
>---
> koha-tmpl/intranet-tmpl/js/browser.js | 3 +++
> 1 file changed, 3 insertions(+)
>
>diff --git a/koha-tmpl/intranet-tmpl/js/browser.js b/koha-tmpl/intranet-tmpl/js/browser.js
>index 81033ea..824e409 100644
>--- a/koha-tmpl/intranet-tmpl/js/browser.js
>+++ b/koha-tmpl/intranet-tmpl/js/browser.js
>@@ -61,6 +61,9 @@ KOHA.browser = function (searchid, biblionumber) {
>         $.cookie(me.searchid, JSON.stringify(me.searchCookie), { path: '/' });
>         $(document).ready(function () {
>             //FIXME It's not a good idea to modify the click events
>+            $('#searchresults table tr a[href*="detail.pl"]').on('click', function (ev) {
>+                ev.preventDefault();
>+            });
>             $('#searchresults table tr a[href*="detail.pl"]').on('mousedown', function (ev) {
>                 if ( ev.which == 2 || ev.which == 1 && ev.ctrlKey ) {
>                     // Middle click or ctrl + click
>-- 
>1.9.1

Actions: View | Diff | Splinter Review

Attachments on bug 11890: 38480 | 38502 | 38640 | 38782 | 38783