Attachment 38786 Details for Bug 10976 – [PASSED QA] Bug 10976: Fix typo itemtype vs itemtypes

[patch] [PASSED QA] Bug 10976: Fix typo itemtype vs itemtypes

PASSED-QA-Bug-10976-Fix-typo-itemtype-vs-itemtypes.patch (text/plain), 1.95 KB, created by Katrin Fischer on 2015-05-03 17:29:14 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: Katrin Fischer

Created: 2015-05-03 17:29:14 UTC

Size: 1.95 KB

patch

obsolete

>From b2eee4828874ee3c6f92df4b9cc83685837d165b Mon Sep 17 00:00:00 2001
>From: Jonathan Druart <jonathan.druart@biblibre.com>
>Date: Wed, 22 Apr 2015 13:22:58 +0200
>Subject: [PATCH] [PASSED QA] Bug 10976: Fix typo itemtype vs itemtypes
>MIME-Version: 1.0
>Content-Type: text/plain; charset=UTF-8
>Content-Transfer-Encoding: 8bit
>
>When creating a new report, the limit step let you choose
>itype|itemtype.
>But it should be itype|itemtypes.
>If you try to create a guided report and you choose this option as a
>limit, you will get a warning on saving it:
>  Errors found when processing parameters for report:
>  itype: The authorized value category (itemtype) you selected does not exist.
>
>Looking at the code: reports/guided_reports.pl l.657
>  elsif ( $authorised_value eq "itemtypes" ) {
>
>Test plan:
>0/ Don't apply the patch
>1/ Create a guided report, select Koha itemtype as a limit(step 4)
>2/ Confirm you get the error when saving
>3/ Apply the patch and repeat step 1
>4/ There is no error and the report should work correctly
>
>Tested with steps in comment #4/#5, error is gone after applying patch.
>Signed-off-by: Marc VÃ©ron <veron@veron.ch>
>
>Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de>
>---
> C4/Reports/Guided.pm | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
>diff --git a/C4/Reports/Guided.pm b/C4/Reports/Guided.pm
>index 1b27e9c..916d373 100644
>--- a/C4/Reports/Guided.pm
>+++ b/C4/Reports/Guided.pm
>@@ -383,7 +383,7 @@ sub get_criteria {
>             my $list;
>             $list='branches' if $column eq 'branchcode' or $column eq 'holdingbranch' or $column eq 'homebranch';
>             $list='categorycode' if $column eq 'categorycode';
>-            $list='itemtype' if $column eq 'itype';
>+            $list='itemtypes' if $column eq 'itype';
>             $list='ccode' if $column eq 'ccode';
>             # TODO : improve to let the librarian choose the description at runtime
>             push @values, { availablevalues => "<<$column".($list?"|$list":'').">>" };
>-- 
>1.9.1

Actions: View | Diff | Splinter Review

Attachments on bug 10976: 38324 | 38657 | 38786