Bugzilla – Attachment 3881 Details for
Bug 6164
messaging tab on staff client loses name
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
Proposed Patch
0001-Bug-6164-Send-Borrower-Data-to-template-consistently.patch (text/plain), 2.39 KB, created by
Colin Campbell
on 2011-04-11 17:10:26 UTC
(
hide
)
Description:
Proposed Patch
Filename:
MIME Type:
Creator:
Colin Campbell
Created:
2011-04-11 17:10:26 UTC
Size:
2.39 KB
patch
obsolete
>From c15460a070db322a1c65f2c29edd8fd61881457a Mon Sep 17 00:00:00 2001 >From: Colin Campbell <colin.campbell@ptfs-europe.com> >Date: Mon, 11 Apr 2011 18:06:29 +0100 >Subject: [PATCH] Bug 6164 Send Borrower Data to template consistently >Content-Type: text/plain; charset="utf-8" > >messaging and notices patron tabs were not passing borrower >info in a manner consistent with other tabs >--- > members/messaging.pl | 4 ++-- > members/notices.pl | 6 +----- > 2 files changed, 3 insertions(+), 7 deletions(-) > >diff --git a/members/messaging.pl b/members/messaging.pl >index ef9cfa4..8791dcf 100755 >--- a/members/messaging.pl >+++ b/members/messaging.pl >@@ -84,7 +84,6 @@ $template->param( messagingview => 1, > message_queue => $message_queue, > DHTMLcalendar_dateformat => C4::Dates->DHTMLcalendar(), > borrowernumber => $borrowernumber, >- branchcode => $borrower->{'branchcode'}, > branchname => GetBranchName($borrower->{'branchcode'}), > dateformat => C4::Context->preference("dateformat"), > categoryname => $borrower->{'description'}, >@@ -94,7 +93,8 @@ $template->param( messagingview => 1, > #$messaging_preferences->{'SMSnumber'}{'value'} = defined $borrower->{'smsalertnumber'} > # ? $borrower->{'smsalertnumber'} : $borrower->{'mobile'}; > >-$template->param( BORROWER_INFO => [ $borrower ], >+$template->param( %{ $borrower } ); >+$template->param( > messagingview => 1, > is_child => ($borrower->{'category_type'} eq 'C'), > ); >diff --git a/members/notices.pl b/members/notices.pl >index f6680d5..088d5a8 100755 >--- a/members/notices.pl >+++ b/members/notices.pl >@@ -51,16 +51,12 @@ $template->param( picture => 1 ) if $picture; > > # Getting the messages > my $queued_messages = C4::Letters::GetQueuedMessages({borrowernumber => $borrowernumber}); >+$template->param( %{$borrower} ); > > $template->param( > QUEUED_MESSAGES => $queued_messages, >- BORROWER_INFO => [ $borrower ], >- firstname => $borrower->{'firstname'}, >- surname => $borrower->{'surname'}, > borrowernumber => $borrowernumber, > sentnotices => 1 > ); > output_html_with_http_headers $input, $cookie, $template->output; > >- >- >-- >1.7.4.2 >
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 6164
:
3871
|
3873
| 3881