Bugzilla – Attachment 38836 Details for
Bug 14144
Silence warnings t/db_dependent/Auth_with_ldap.t
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
Bug 14144: Silence warnings in t/db_dependent/Auth_with_ldap.t
Bug-14144-Silence-warnings-in-tdbdependentAuthwith.patch (text/plain), 1.58 KB, created by
Mark Tompsett
on 2015-05-05 02:20:52 UTC
(
hide
)
Description:
Bug 14144: Silence warnings in t/db_dependent/Auth_with_ldap.t
Filename:
MIME Type:
Creator:
Mark Tompsett
Created:
2015-05-05 02:20:52 UTC
Size:
1.58 KB
patch
obsolete
>From 22db0077ed21642fd8062714e329536a81df2c80 Mon Sep 17 00:00:00 2001 >From: Mark Tompsett <mtompset@hotmail.com> >Date: Mon, 4 May 2015 21:59:15 -0400 >Subject: [PATCH] Bug 14144: Silence warnings in > t/db_dependent/Auth_with_ldap.t > >TEST PLAN >---------- >1) prove t/db_dependent/Auth_with_ldap.t > -- there is a shibboleth related warning >2) apply patch >3) prove t/db_dependent/Auth_with_ldap.t > -- now there is not. >4) koha qa test tools. > >NOTE: Further investigation determined this would merely > delay it, as the function is not called by this test. > A delay is better than nothing. >--- > C4/Auth_with_ldap.pm | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > >diff --git a/C4/Auth_with_ldap.pm b/C4/Auth_with_ldap.pm >index 58484a2..7676f19 100644 >--- a/C4/Auth_with_ldap.pm >+++ b/C4/Auth_with_ldap.pm >@@ -27,7 +27,6 @@ use C4::Members qw(AddMember changepassword); > use C4::Members::Attributes; > use C4::Members::AttributeTypes; > use C4::Members::Messaging; >-use C4::Auth qw(checkpw_internal); > use Koha::AuthUtils qw(hash_password); > use List::MoreUtils qw( any ); > use Net::LDAP; >@@ -326,7 +325,8 @@ sub _do_changepassword { > $debug and print STDERR "changing local password for borrowernumber=$borrowerid to '$digest'\n"; > changepassword($userid, $borrowerid, $digest); > >- my ($ok, $cardnum) = checkpw_internal(C4::Context->dbh, $userid, $password); >+ require C4::Auth; >+ my ($ok, $cardnum) = C4::Auth::checkpw_internal(C4::Context->dbh, $userid, $password); > return $cardnum if $ok; > > warn "Password mismatch after update to borrowernumber=$borrowerid"; >-- >2.1.4
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 14144
:
38835
|
38836
|
49882
|
49883
|
49884
|
49885
|
49886
|
50538
|
50539
|
50540
|
50920
|
50921