Attachment 38839 Details for Bug 14145 – Bug 14145: Noisy warns in admin/preferences.pl on Enhanced Content tab

[patch] Bug 14145: Noisy warns in admin/preferences.pl on Enhanced Content tab

Bug-14145-Noisy-warns-in-adminpreferencespl-on-Enh.patch (text/plain), 1.06 KB, created by Aleisha Amohia on 2015-05-05 05:49:09 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: Aleisha Amohia

Created: 2015-05-05 05:49:09 UTC

Size: 1.06 KB

patch

obsolete

>From 2ff152282ca8099ad8ae7d1bbc27d4dd5d8da22f Mon Sep 17 00:00:00 2001
>From: Aleisha <aleishaamohia@hotmail.com>
>Date: Tue, 5 May 2015 03:32:35 +0000
>Subject: [PATCH] Bug 14145: Noisy warns in admin/preferences.pl on Enhanced
> Content tab
>
>'Use of uninitialized value $value in split' on line 109, fixed by setting $value to an empty string.
>
>To test:
>
>1) Go to Admin -> System preferences
>2) Click on Enhanced content tab
>3) Notice warns in error log
>4) Apply patch and refresh page
>5) Notice page still works but no warns in error log
>---
> admin/preferences.pl |    1 +
> 1 file changed, 1 insertion(+)
>
>diff --git a/admin/preferences.pl b/admin/preferences.pl
>index 96013b2..415c9af 100755
>--- a/admin/preferences.pl
>+++ b/admin/preferences.pl
>@@ -62,6 +62,7 @@ sub _get_chunk {
> 
>     my $name = $options{'pref'};
>     my $chunk = { name => $name, value => $value, type => $options{'type'} || 'input', class => $options{'class'} };;
>+    $value //= '';
> 
>     if ( $options{'class'} && $options{'class'} eq 'password' ) {
>         $chunk->{'input_type'} = 'password';
>-- 
>1.7.10.4

Actions: View | Diff | Splinter Review

Attachments on bug 14145: 38838 | 38839 | 38999 | 39051 | 39384