Attachment 38880 Details for Bug 14153 – Bug 14153: Noisy warns in admin/transport-cost-matrix.pl

[patch] Bug 14153: Noisy warns in admin/transport-cost-matrix.pl

Bug-14153-Noisy-warns-in-admintransport-cost-matri.patch (text/plain), 1.22 KB, created by Aleisha Amohia on 2015-05-06 04:54:10 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: Aleisha Amohia

Created: 2015-05-06 04:54:10 UTC

Size: 1.22 KB

patch

obsolete

>From 0eb8a34e01373a31ebc8becd89455b7cb82443d6 Mon Sep 17 00:00:00 2001
>From: Aleisha <aleishaamohia@hotmail.com>
>Date: Wed, 6 May 2015 02:37:29 +0000
>Subject: [PATCH] Bug 14153: Noisy warns in admin/transport-cost-matrix.pl
>
>This patch silences the warn by putting curly braces around the $input->param('op') code, to kind of group this as a variable. I don't know that this is the best solution for this but the warn is no longer there.
>
>To test:
>
>1) Go to Admin -> Transport cost matrix
>2) Notice the warns in the error log
>3) Apply the patch and refresh page
>4) Notice page still works but no warns in error log
>---
> admin/transport-cost-matrix.pl |    2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
>diff --git a/admin/transport-cost-matrix.pl b/admin/transport-cost-matrix.pl
>index 3197306..daf8b1c 100755
>--- a/admin/transport-cost-matrix.pl
>+++ b/admin/transport-cost-matrix.pl
>@@ -42,7 +42,7 @@ my ($template, $loggedinuser, $cookie)
>                             });
> my $use_transport_cost_matrix = C4::Context->preference("UseTransportCostMatrix");
> 
>-my $update = $input->param('op') eq 'set-cost-matrix';
>+my $update = {$input->param('op')} eq 'set-cost-matrix';
> 
> my ($cost_matrix, $have_matrix);
> unless ($update) {
>-- 
>1.7.10.4

Actions: View | Diff | Splinter Review

Attachments on bug 14153: 38880 | 45628 | 46011 | 46065