Attachment 38969 Details for Bug 9892 – Bug 9892: Make export_borrowers.pl using the delimiter pref

[patch] Bug 9892: Make export_borrowers.pl using the delimiter pref

Bug-9892-Make-exportborrowerspl-using-the-delimite.patch (text/plain), 1.56 KB, created by Marcel de Rooy on 2015-05-08 07:35:17 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: Marcel de Rooy

Created: 2015-05-08 07:35:17 UTC

Size: 1.56 KB

patch

obsolete

>From 177b826335f415dbed079d4f84dbebbaf89fa5c5 Mon Sep 17 00:00:00 2001
>From: Jonathan Druart <jonathan.druart@biblibre.com>
>Date: Thu, 9 Apr 2015 15:49:14 +0200
>Subject: [PATCH] Bug 9892: Make export_borrowers.pl using the delimiter pref
>Content-Type: text/plain; charset=utf-8
>
>The original concern of bug 9892 was that this borrowers export script
>cannot handle tabulation to separate columns.
>
>With this patch, the delimiter preference is used as separator for the
>output, to be consistent with others scripts.
>
>This should be highlighted on the release, it can produce change in
>behaviors.
>
>Test plan:
>Confirm that the 'delimiter' pref is used for the output, but you are able
>to overwrite it with the 'separator' parameter
>
>Signed-off-by: Bernardo Gonzalez Kriegel <bgkriegel@gmail.com>
>Works as expected, respect preference but is supeseeded by cmd line
>No koha-qa errors
>
>Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl>
>---
> misc/export_borrowers.pl |    5 +++++
> 1 file changed, 5 insertions(+)
>
>diff --git a/misc/export_borrowers.pl b/misc/export_borrowers.pl
>index a9ecb3d..4f29f31 100755
>--- a/misc/export_borrowers.pl
>+++ b/misc/export_borrowers.pl
>@@ -87,6 +87,11 @@ $query .= " ORDER BY borrowernumber";
> my $sth   = $dbh->prepare($query);
> $sth->execute;
> 
>+unless ( $separator ) {
>+    $separator = C4::Context->preference('delimiter') || ',';
>+    $separator = "\t" if ($separator eq 'tabulation');
>+}
>+
> my $csv = Text::CSV->new( { sep_char => $separator, binary => 1 } );
> 
> # If the user did not specify any field to export, we assume he wants them all
>-- 
>1.7.10.4

Actions: View | Diff | Splinter Review

Attachments on bug 9892: 37619 | 38895 | 38967 | 38968 | 38969 | 38970