Attachment 39057 Details for Bug 14186 – Bug 14186: Undefined $reservedfor causes warn in opac-reserve.pl

[patch] Bug 14186: Undefined $reservedfor causes warn in opac-reserve.pl

Bug-14186-Undefined-reservedfor-causes-warn-in-opa.patch (text/plain), 1.17 KB, created by Aleisha Amohia on 2015-05-12 05:48:23 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: Aleisha Amohia

Created: 2015-05-12 05:48:23 UTC

Size: 1.17 KB

patch

obsolete

>From dfe64407210e047ceda2fddcc6bc1a08bf705a8f Mon Sep 17 00:00:00 2001
>From: Aleisha <aleishaamohia@hotmail.com>
>Date: Tue, 12 May 2015 03:30:46 +0000
>Subject: [PATCH] Bug 14186: Undefined $reservedfor causes warn in
> opac-reserve.pl
>
>This patch sets $reservedfor to an empty string.
>
>To test:
>
>1) On the OPAC, do a simple search for an item that will return results (ie by Keyword, search for "a")
>2) Click Place Hold on any item
>3) Notice warn in error log
>4) Apply patch
>5) Reload page (attempt to Place Hold)
>6) Notice page still works but no warns
>---
> opac/opac-reserve.pl |    3 ++-
> 1 file changed, 2 insertions(+), 1 deletion(-)
>
>diff --git a/opac/opac-reserve.pl b/opac/opac-reserve.pl
>index 5ab4c34..51402b8 100755
>--- a/opac/opac-reserve.pl
>+++ b/opac/opac-reserve.pl
>@@ -466,7 +466,8 @@ foreach my $biblioNum (@biblionumbers) {
>         my $ItemBorrowerReserveInfo = GetMemberDetails( $reservedfor, 0);
> 
>         # the item could be reserved for this borrower vi a host record, flag this
>-        if ($reservedfor eq $borrowernumber){
>+        $reservedfor //= '';
>+	if ($reservedfor eq $borrowernumber){
>             $itemLoopIter->{already_reserved} = 1;
>         }
> 
>-- 
>1.7.10.4

Actions: View | Diff | Splinter Review

Attachments on bug 14186: 39057 | 39175 | 39176 | 39399 | 39400 | 39401 | 39402