Attachment 3912 Details for Bug 3514 – Proposed incremental fix

[patch] Proposed incremental fix

0001-Incremental-fix-for-Bug-3514-Returning-items-through.patch (text/plain), 4.63 KB, created by Owen Leonard on 2011-04-13 16:23:42 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: Owen Leonard

Created: 2011-04-13 16:23:42 UTC

Size: 4.63 KB

patch

obsolete

>From 70e59cefd7fcd41272418b6d483bc6e6da2c3e69 Mon Sep 17 00:00:00 2001
>From: Owen Leonard <oleonard@myacpl.org>
>Date: Wed, 13 Apr 2011 11:25:07 -0400
>Subject: [PATCH] Incremental fix for Bug 3514, Returning items through patron details tab
>Content-Type: text/plain; charset="utf-8"
>
>Hiding the "check in" checkbox for items which are on hold. This
>mitigates the problem of checkins not triggering holds prompts
>by forcing the librarian to check in these items individually.
>
>This fix should be considered temporary until a more comprehensive
>fix can be developed which incorporates handling for holds.
>---
> .../prog/en/modules/circ/circulation.tt            |   16 ++++++++++++++--
> .../prog/en/modules/members/moremember.tt          |    4 ++++
> 2 files changed, 18 insertions(+), 2 deletions(-)
>
>diff --git a/koha-tmpl/intranet-tmpl/prog/en/modules/circ/circulation.tt b/koha-tmpl/intranet-tmpl/prog/en/modules/circ/circulation.tt
>index f383c21..1c5c799 100644
>--- a/koha-tmpl/intranet-tmpl/prog/en/modules/circ/circulation.tt
>+++ b/koha-tmpl/intranet-tmpl/prog/en/modules/circ/circulation.tt
>@@ -718,7 +718,7 @@ No patron matched <span class="ex">[% message %]</span>
>                 <span class="renewals-disabled">
>             [% END %]
> 		[% IF ( todayissue.renew_error_on_reserve ) %]
>-			On Hold
>+			<a href="/cgi-bin/koha/reserve/request.pl?biblionumber=[% todayissue.biblionumber %]">On Hold</a>
> 		[% END %]
>                 [% IF ( todayissue.renew_error_too_many ) %]
> 			Not Renewable
>@@ -732,9 +732,15 @@ No patron matched <span class="ex">[% message %]</span>
>   [% IF ( todayissue.return_failed ) %]
>             <td class="problem">Checkin Failed</td>
>       [% ELSE %]
>+            [% IF ( todayissue.renew_error_on_reserve ) %]
>+               <td><a href="/cgi-bin/koha/reserve/request.pl?biblionumber=[% todayissue.biblionumber %]">On Hold</a>
>+                <input type="checkbox" name="all_barcodes[]" value="[% todayissue.barcode %]" checked="checked" style="display: none;" />
>+                </td>
>+            [% ELSE %]
>             <td><input type="checkbox" class="radio" name="barcodes[]"  value="[% todayissue.barcode %]" />
>                 <input type="checkbox" name="all_barcodes[]" value="[% todayissue.barcode %]" checked="checked" style="display: none;" />
>             </td>
>+            [% END %]
>       [% END %]
>     </tr>
>     [% END %] 
>@@ -786,7 +792,7 @@ No patron matched <span class="ex">[% message %]</span>
>                 <span class="renewals-disabled">
>             [% END %]
> 		[% IF ( previssue.renew_error_on_reserve ) %]
>-			On Hold
>+			<a href="/cgi-bin/koha/reserve/request.pl?biblionumber=[% previssue.biblionumber %]">On Hold</a>
> 		[% END %]
>                 [% IF ( previssue.renew_error_too_many ) %]
> 			Not Renewable
>@@ -800,9 +806,15 @@ No patron matched <span class="ex">[% message %]</span>
> 		  [% IF ( previssue.return_failed ) %]
>             <td class="problem">Checkin Failed</td>
>         [% ELSE %]
>+            [% IF ( previssue.renew_error_on_reserve ) %]
>+               <td><a href="/cgi-bin/koha/reserve/request.pl?biblionumber=[% previssue.biblionumber %]">On Hold</a>
>+                <input type="checkbox" name="all_barcodes[]" value="[% previssue.barcode %]" checked="checked" style="display: none;" />
>+                </td>
>+            [% ELSE %]
>             <td><input type="checkbox" class="radio" name="barcodes[]"  value="[% previssue.barcode %]" />
>                 <input type="checkbox" name="all_barcodes[]" value="[% previssue.barcode %]" checked="checked" style="display: none;" />
>             </td>
>+            [% END %]
>       [% END %]
>     </tr>
>     [% END %]
>diff --git a/koha-tmpl/intranet-tmpl/prog/en/modules/members/moremember.tt b/koha-tmpl/intranet-tmpl/prog/en/modules/members/moremember.tt
>index 9fb1736..ef52555 100644
>--- a/koha-tmpl/intranet-tmpl/prog/en/modules/members/moremember.tt
>+++ b/koha-tmpl/intranet-tmpl/prog/en/modules/members/moremember.tt
>@@ -493,9 +493,13 @@ function validate1(date) {
>       [% IF ( issueloo.return_failed ) %]
>             <td class="problem">Checkin Failed</td>
>       [% ELSE %]
>+        [% IF ( issueloo.norenew_reason_on_reserve ) %]
>+            <td><a href="/cgi-bin/koha/reserve/request.pl?biblionumber=[% issueloo.biblionumber %]">On Hold</a></td>
>+        [% ELSE %]
>             <td><input type="checkbox" name="barcodes[]"  value="[% issueloo.barcode %]" onclick="uncheck_sibling(this);" />
>                 <input type="checkbox" name="all_barcodes[]" value="[% issueloo.barcode %]" checked="checked" style="display: none;" />
>             </td>
>+        [% END %]
>       [% END %]
>         </tr>
>   [% END %]
>-- 
>1.7.3
>

Actions: View | Diff | Splinter Review

Attachments on bug 3514: 1378 | 3912