Bugzilla – Attachment 39134 Details for
Bug 14194
Date due for on-site checkouts defaults to 00:00 for hh:mm
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
Bug 14194: Restore the HH:MM to 23:59 for onsite-checkouts
Bug-14194-Restore-the-HHMM-to-2359-for-onsite-chec.patch (text/plain), 1.75 KB, created by
Jonathan Druart
on 2015-05-13 13:56:42 UTC
(
hide
)
Description:
Bug 14194: Restore the HH:MM to 23:59 for onsite-checkouts
Filename:
MIME Type:
Creator:
Jonathan Druart
Created:
2015-05-13 13:56:42 UTC
Size:
1.75 KB
patch
obsolete
>From f699f962684b9e8d0367206863973a816b06a706 Mon Sep 17 00:00:00 2001 >From: Jonathan Druart <jonathan.druart@biblibre.com> >Date: Tue, 12 May 2015 13:11:40 +0200 >Subject: [PATCH] Bug 14194: Restore the HH:MM to 23:59 for onsite-checkouts > >(Introduced by bug 13601) > >Test plan: >1/ Enable On-site checkouts >2/ Go on the checkouts page >3/ Click on the "On-site checkout" checkbox >=> The default date due should be today with 23:59 as HH:MM (not 00:00). > >Technical note: There is a confusion with iso and sql date formats at >some places in the code. >A better way should be provided (later) to fix globally the mismatch >between these 2 formats. >What happened before this patch: the DateTime was cast to a string and >the template received "YYYY-MM-DDTHH:MM:SS" which is an iso formatted >date. BUT this format is not managed by Koha::DateUtils::output_pref >("iso" and "sql" are considered as indentical which is wrong). >As I did not estimated the problem (how big it is) I prefer to fix it >easily (and dirty) for now. >--- > circ/circulation.pl | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > >diff --git a/circ/circulation.pl b/circ/circulation.pl >index ab47895..ab6db3b 100755 >--- a/circ/circulation.pl >+++ b/circ/circulation.pl >@@ -587,7 +587,7 @@ $template->param( > AllowRenewalLimitOverride => C4::Context->preference("AllowRenewalLimitOverride"), > canned_bor_notes_loop => $canned_notes, > debarments => GetDebarments({ borrowernumber => $borrowernumber }), >- todaysdate => dt_from_string()->set(hour => 23)->set(minute => 59), >+ todaysdate => output_pref( { dt => dt_from_string()->set(hour => 23)->set(minute => 59), dateformat => 'sql' } ), > ); > > output_html_with_http_headers $query, $cookie, $template->output; >-- >2.1.0
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 14194
:
39134
|
39137
|
39145
|
39187