Bugzilla – Attachment 39146 Details for
Bug 14197
Warning raised by TestBuilder
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
Bug 14197: Remove the warning on destroying TestBuilder objects
Bug-14197-Remove-the-warning-on-destroying-TestBui.patch (text/plain), 894 bytes, created by
Jonathan Druart
on 2015-05-13 16:02:12 UTC
(
hide
)
Description:
Bug 14197: Remove the warning on destroying TestBuilder objects
Filename:
MIME Type:
Creator:
Jonathan Druart
Created:
2015-05-13 16:02:12 UTC
Size:
894 bytes
patch
obsolete
>From 1b7a0c289bfcf5ddaf111bd58c91ce03605bf0c3 Mon Sep 17 00:00:00 2001 >From: Jonathan Druart <jonathan.druart@koha-community.org> >Date: Wed, 13 May 2015 17:58:45 +0200 >Subject: [PATCH] Bug 14197: Remove the warning on destroying TestBuilder > objects > >This module will be called by db_dependent tests, which already create a >transaction. >TestBuilder creates a new one (which is certainly useless) and the >rollback does not do anything. > >To see the warning see patches on bug 14045. >--- > t/lib/TestBuilder.pm | 4 +++- > 1 file changed, 3 insertions(+), 1 deletion(-) > >diff --git a/t/lib/TestBuilder.pm b/t/lib/TestBuilder.pm >index 72364e3..5c8ee8b 100644 >--- a/t/lib/TestBuilder.pm >+++ b/t/lib/TestBuilder.pm >@@ -315,7 +315,9 @@ sub _gen_blob { > > sub DESTROY { > my $self = shift; >- $self->schema->txn_rollback(); >+ eval { >+ $self->schema->txn_rollback(); >+ }; > } > > >-- >2.1.0
<b>You cannot view the attachment while viewing its details because your browser does not support IFRAMEs. <a href="attachment.cgi?id=39146">View the attachment on a separate page</a>.</b>
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 14197
:
39146
|
40859
|
42055
|
42056
|
42057
|
42058
|
42059
|
42545
|
42546