Attachment 39216 Details for Bug 13656 – [SIGNED-OFF] Bug 13656: "Change"/"Set to patron" button for linking a member to an organisation (or child to guarantor) not translatable

[patch] [SIGNED-OFF] Bug 13656: "Change"/"Set to patron" button for linking a member to an organisation (or child to guarantor) not translatable

SIGNED-OFF-Bug-13656-ChangeSet-to-patron-button-fo.patch (text/plain), 2.11 KB, created by Bernardo Gonzalez Kriegel on 2015-05-15 18:06:19 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: Bernardo Gonzalez Kriegel

Created: 2015-05-15 18:06:19 UTC

Size: 2.11 KB

patch

obsolete

>From 02ea64d013ac81f7961414e27cda37b5d175ae2a Mon Sep 17 00:00:00 2001
>From: Josef Moravec <josef.moravec@gmail.com>
>Date: Fri, 15 May 2015 11:03:21 +0200
>Subject: [PATCH] [SIGNED-OFF] Bug 13656: "Change"/"Set to patron" button for
> linking a member to an organisation (or child to guarantor)
> not translatable
>
>Test plan:
>1. install and activate an additional language
>2. create patron in organization category
>3. create professional patron
>4. try to add this patron to an organization (Guarantor information section)
>5. note that the left button text changed to "Change" - untranslated english string
>6. push the "Delete" button, the guarantor patron field is cleared and the left button text changed to "Set to patron" - again original english text
>7. apply the patch
>7.1. update translation (koha-translate -u language_code)
>8. repeat 4-6, note, that button text are still translated in all sitations
>9. sign off ;)
>
>Signed-off-by: Bernardo Gonzalez Kriegel <bgkriegel@gmail.com>
>Work as described, no errors
>Fixed message capitalization
>---
> .../prog/en/modules/members/memberentrygen.tt      |    4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
>diff --git a/koha-tmpl/intranet-tmpl/prog/en/modules/members/memberentrygen.tt b/koha-tmpl/intranet-tmpl/prog/en/modules/members/memberentrygen.tt
>index 330058f..82025f6 100644
>--- a/koha-tmpl/intranet-tmpl/prog/en/modules/members/memberentrygen.tt
>+++ b/koha-tmpl/intranet-tmpl/prog/en/modules/members/memberentrygen.tt
>@@ -14,7 +14,7 @@
>             $("#contactname, #contactfirstname")
>                 .each(function () { this.type = 'text' })
>                 .parent().find('span').remove();
>-            $("#guarantorsearch").val("Set to Patron");
>+            $("#guarantorsearch").val(_("Set to patron"));
>         });
>         $("#select_city").change(function(){
>             var myRegEx=new RegExp(/(.*)\|(.*)\|(.*)\|(.*)/);
>@@ -129,7 +129,7 @@
>         form.country.value = borrower.country;
>         form.branchcode.value = borrower.branchcode;
> 
>-        form.guarantorsearch.value = 'Change';
>+        form.guarantorsearch.value = _("Change");
> 
>         return 0;
>     }
>-- 
>1.7.9.5

Actions: View | Diff | Splinter Review

Attachments on bug 13656: 39208 | 39209 | 39215 | 39216 | 39534 | 40160