Bugzilla – Attachment 39217 Details for
Bug 14204
Fix t/db_dependent/Labels/t_Batch.t failing test from Bug 12911
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
[PASSED QA] Bug 14204: Fix t/db_dependent/Labels/t_Batch.t failing test from Bug 12991
PASSED-QA-Bug-14204-Fix-tdbdependentLabelstBatcht-.patch (text/plain), 1.31 KB, created by
Tomás Cohen Arazi (tcohen)
on 2015-05-15 18:30:52 UTC
(
hide
)
Description:
[PASSED QA] Bug 14204: Fix t/db_dependent/Labels/t_Batch.t failing test from Bug 12991
Filename:
MIME Type:
Creator:
Tomás Cohen Arazi (tcohen)
Created:
2015-05-15 18:30:52 UTC
Size:
1.31 KB
patch
obsolete
>From 6224b7503a3c583818fab35989d831be26147365 Mon Sep 17 00:00:00 2001 >From: Nick Clemens <nick@quecheelibrary.org> >Date: Thu, 14 May 2015 19:56:43 +0000 >Subject: [PATCH] [PASSED QA] Bug 14204: Fix t/db_dependent/Labels/t_Batch.t > failing test from Bug 12991 > >This patch updaes the batch_id variable after items are added to test batch > >To test: >1. prove t/db_dependent/Labels/t_Batch.t and see two tests fail >2. apply patch >3. prove again, tests pass! > >Signed-off-by: Mark Tompsett <mtompset@hotmail.com> > >NOTE: The $batch->add_item() call to C4::Creators::Batch::add_item > triggers the change of the batch_id so this line is necessary! >Signed-off-by: Tomas Cohen Arazi <tomascohen@gmail.com> >--- > t/db_dependent/Labels/t_Batch.t | 1 + > 1 file changed, 1 insertion(+) > >diff --git a/t/db_dependent/Labels/t_Batch.t b/t/db_dependent/Labels/t_Batch.t >index 95f7b40..1fedec8 100644 >--- a/t/db_dependent/Labels/t_Batch.t >+++ b/t/db_dependent/Labels/t_Batch.t >@@ -94,6 +94,7 @@ my $itemnumbers = $iteminfo[0]; > for my $itemnumber ( @$itemnumbers ) { > ok($batch->add_item($itemnumber) eq 0 ) || diag "Batch->add_item() FAILED."; > } >+$batch_id=$batch->get_attr('batch_id'); > > diag "Testing Batch->retrieve() method."; > ok(my $saved_batch = C4::Labels::Batch->retrieve(batch_id => $batch_id)) || diag "Batch->retrieve() FAILED."; >-- >2.4.0
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 14204
:
39203
|
39213
| 39217 |
39218
|
39219